Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Unified Diff: net/url_request/url_request_http_job.h

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Initial patch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.h
diff --git a/net/url_request/url_request_http_job.h b/net/url_request/url_request_http_job.h
index 26ad8d2797512d8da5d43bb501c36a0811356366..4b09fce4013c80b6ff092a2286afa0ac7249b913 100644
--- a/net/url_request/url_request_http_job.h
+++ b/net/url_request/url_request_http_job.h
@@ -181,6 +181,8 @@ class NET_EXPORT_PRIVATE URLRequestHttpJob : public URLRequestJob {
bool read_in_progress_;
+ // Always invoke Orphan on the transaction and never let it get destroyed
+ // implicitly.
std::unique_ptr<HttpTransaction> transaction_;
// This is used to supervise traffic and enforce exponential

Powered by Google App Engine
This is Rietveld 408576698