Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: net/http/http_transaction.h

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Initial patch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_transaction.h
diff --git a/net/http/http_transaction.h b/net/http/http_transaction.h
index eff45d10c5648d618e4366a6ea91a398b06016b1..ad3b291f817730d0d7d8786a8b2e789b79abdb26 100644
--- a/net/http/http_transaction.h
+++ b/net/http/http_transaction.h
@@ -72,6 +72,11 @@ class NET_EXPORT_PRIVATE HttpTransaction {
const CompletionCallback& callback,
const NetLogWithSource& net_log) = 0;
+ // Ownership of the transaction is transferred from the consumer to the
jkarlin 2016/12/06 18:08:18 s/from the consumer to the transaction/to the tran
shivanisha 2016/12/06 21:53:35 done.
+ // transaction. It can be either reset in the method or reset can be deferred
+ // if some asynchronous operation is in progress.
+ virtual void Orphan(std::unique_ptr<HttpTransaction> trans) = 0;
jkarlin 2016/12/06 18:08:18 Let's move this method to the bottom of the public
shivanisha 2016/12/06 21:53:35 done.
+
// Restarts the HTTP transaction, ignoring the last error. This call can
// only be made after a call to Start (or RestartIgnoringLastError) failed.
// Once Read has been called, this method cannot be called. This method is

Powered by Google App Engine
This is Rietveld 408576698