Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Initial patch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 28f8a1ee1a5d16e9c3170cb97b13e036046bbdcf..b9c8a0185a1d795b4d54b19635e139bc48fcab37 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -261,6 +261,9 @@ URLRequestHttpJob::~URLRequestHttpJob() {
DestroySourceStream();
DoneWithRequest(ABORTED);
+ if (transaction_) {
+ transaction_->Orphan(std::move(transaction_));
+ }
}
void URLRequestHttpJob::SetPriority(RequestPriority priority) {
@@ -437,7 +440,7 @@ void URLRequestHttpJob::DestroyTransaction() {
transaction_->GetTotalReceivedBytes();
total_sent_bytes_from_previous_transactions_ +=
transaction_->GetTotalSentBytes();
- transaction_.reset();
+ transaction_->Orphan(std::move(transaction_));
response_info_ = NULL;
receive_headers_end_ = base::TimeTicks();
}

Powered by Google App Engine
This is Rietveld 408576698