Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_ftp_job.cc

Issue 2519473002: Fixes the cache lock issue. (Closed)
Patch Set: Initial patch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/http/http_transaction.h ('K') | « net/http/http_transaction_test_util.cc ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_ftp_job.cc
diff --git a/net/url_request/url_request_ftp_job.cc b/net/url_request/url_request_ftp_job.cc
index dcb914a878d6963a690f27898358a93d73c2f923..944070e04fa5107618442eb6c8d4b63085c23418 100644
--- a/net/url_request/url_request_ftp_job.cc
+++ b/net/url_request/url_request_ftp_job.cc
@@ -134,7 +134,7 @@ void URLRequestFtpJob::Kill() {
if (ftp_transaction_)
ftp_transaction_.reset();
if (http_transaction_)
- http_transaction_.reset();
+ http_transaction_->Orphan(std::move(http_transaction_));
URLRequestJob::Kill();
weak_factory_.InvalidateWeakPtrs();
}
« net/http/http_transaction.h ('K') | « net/http/http_transaction_test_util.cc ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698