DevTools: move message management from UISourceCodeFrame to UISourceCode

DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
Committed: https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046
Cr-Commit-Position: refs/heads/master@{#434819}

[lushnikov, 2016-11-23 03:01:22]

Description was changed from

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

to

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages. This
will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

[lushnikov, 2016-11-23 03:01:45]

Description was changed from

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages. This
will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

to

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

[lushnikov, 2016-11-23 03:02:43]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-11-23 03:02:43]

please, take a look

[lushnikov, 2016-11-23 04:27:22]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 04:27:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 06:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 06:07:10]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-23 22:24:41]

lgtm

https://codereview.chromium.org/2514323008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2514323008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:464:
_fireWorkingCopyChanged() {
_workingCopyChanged

[lushnikov, 2016-11-23 23:27:15]

https://codereview.chromium.org/2514323008/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2514323008/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:464:
_fireWorkingCopyChanged() {
On 2016/11/23 22:24:41, dgozman wrote:
> _workingCopyChanged

Done.

[lushnikov, 2016-11-23 23:27:18]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-23 23:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2514323008/#ps30001
(title: "address comments")

[commit-bot: I haz the power, 2016-11-23 23:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 01:29:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 01:29:49]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[lushnikov, 2016-11-24 11:26:23]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:26:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:28:08]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[lushnikov, 2016-11-28 18:27:03]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-28 18:27:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 19:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 19:58:16]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[lushnikov, 2016-11-28 23:14:39]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:16:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 01:45:09]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1480374879703000,
"parent_rev": "f34bb743bb4a18d059c527300220a4039034a53d", "commit_rev":
"7266dea9f7efd387478c9a27605ec9d408176777"}

[commit-bot: I haz the power, 2016-11-29 01:45:32]

Description was changed from

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

to

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

[commit-bot: I haz the power, 2016-11-29 01:45:34]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-11-29 01:48:05]

Description was changed from

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837
==========

to

==========
DevTools: move message management from UISourceCodeFrame to UISourceCode

Today, UISourceCodeFrame removes all messages from UISourceCode whenever
the working copy of UISourceCode gets changed. This is a "wag the dog"
situation.

This patch makes UISourceCode to decide on the lifetime on its messages.
This will help to implement the message merging logic.

Drive-by: converts UISourceCodeFrame._rawMessageBucket into Map.

BUG=649837

Committed: https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046
Cr-Commit-Position: refs/heads/master@{#434819}
==========

[commit-bot: I haz the power, 2016-11-29 01:48:06]

Patchset 3 (id:??) landed as
https://crrev.com/f0fe6d5aaedd8efaedfc651c92e4e9eda31c2046
Cr-Commit-Position: refs/heads/master@{#434819}