third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html - Issue 2514323008: DevTools: move message management from UISourceCodeFrame to UISourceCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html

Issue 2514323008: DevTools: move message management from UISourceCodeFrame to UISourceCode (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html

diff --git a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html

index a4bdc3e33c78bd0d1504eb58182b75a8d2847030..91ba30756d5ce2b665e9e9caed0d132856418f1a 100644

--- a/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html

+++ b/third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console.html

@@ -50,7 +50,7 @@ var test = function()

{

dumpConsoleMessageURLs();

InspectorTest.addResult("Pre-format row message list:");

- InspectorTest.addResult(JSON.stringify(Object.keys(sourceFrame._rowMessageBuckets)));

+ InspectorTest.addResult(JSON.stringify(sourceFrame._rowMessageBuckets.keysArray()));

var name = panel.visibleView.uiSourceCode().name();

scriptFormatter._toggleFormatScriptSource();

InspectorTest.showScriptSource(name + ":formatted", uiSourceCodeScriptFormatted);

@@ -61,7 +61,7 @@ var test = function()

dumpConsoleMessageURLs();

InspectorTest.addResult("Post-format row message list:");

var formattedSourceFrame = panel.visibleView;

- InspectorTest.addResult(JSON.stringify(Object.keys(formattedSourceFrame._rowMessageBuckets)));

+ InspectorTest.addResult(JSON.stringify(formattedSourceFrame._rowMessageBuckets.keysArray()));

next();

}