third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html - Issue 2514323008: DevTools: move message management from UISourceCodeFrame to UISourceCode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html

Issue 2514323008: DevTools: move message management from UISourceCodeFrame to UISourceCode (Closed)

Patch Set: address comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-enabled/sources/debugger/script-formatter-console-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html b/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html

index 18a8d6e5daa05e6b0c7b8f74dce7684225ea2a9d..1958b8ca335d9af6543d645cb080139856874f8e 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript.html

@@ -19,9 +19,8 @@ function test()

function onCompilationFinished(sourceFrame)

{

- for (var line in sourceFrame._rowMessageBuckets) {

- var bubble = sourceFrame._rowMessageBuckets[line];

- for (var rowMessage of bubble._messages) {

+ for (var bucket of sourceFrame._rowMessageBuckets.values()) {

+ for (var rowMessage of bucket._messages) {

var message = rowMessage.message();

InspectorTest.addResult(String.sprintf("%d:%d [%s] %s", message.lineNumber(), message.columnNumber(), message.level(), message.text()));

}