DevTools: teach UISourceCodeFrame to merge messages

DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman

Committed: https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d
Cr-Commit-Position: refs/heads/master@{#434847}

[lushnikov, 2016-11-23 04:25:38]

Description was changed from

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman
==========

to

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman
==========

[lushnikov, 2016-11-23 04:25:46]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 04:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-23 04:57:09]

please, take a look

[commit-bot: I haz the power, 2016-11-23 05:41:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 05:41:03]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-23 23:07:56]

lgtm

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt
(right):

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt:1:
Verify that breakpoints are moved appropriately
Messages!

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt:11:
SourceFrame http://127.0.0.1:8000/inspector/persistence/resources/foo.js: 2
message(s)
Let's also dump for FS source frame.

[lushnikov, 2016-11-24 00:15:50]

all done, thanks!

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt
(right):

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt:1:
Verify that breakpoints are moved appropriately
On 2016/11/23 23:07:56, dgozman wrote:
> Messages!

Done.

https://codereview.chromium.org/2530483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-sourceframe-messages-expected.txt:11:
SourceFrame http://127.0.0.1:8000/inspector/persistence/resources/foo.js: 2
message(s)
On 2016/11/23 23:07:56, dgozman wrote:
> Let's also dump for FS source frame.

Done.

[lushnikov, 2016-11-24 00:15:57]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 00:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 02:19:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 02:19:10]

Dry run: Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[lushnikov, 2016-11-28 18:27:20]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-28 18:28:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 21:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-28 21:21:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, no
build URL)

[lushnikov, 2016-11-29 00:33:29]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-29 00:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-11-29 01:36:37]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2016-11-29 01:36:41]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-29 01:36:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2530483002/#ps20001
(title: "improve test")

[commit-bot: I haz the power, 2016-11-29 01:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:37:29]

This CL has an open dependency (Issue 2514323008 Patch 30001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[lushnikov, 2016-11-29 01:46:32]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-11-29 01:47:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:53:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480383992445090,
"parent_rev": "1c15105916c592994d24a5fb261a6840ffd2a6f2", "commit_rev":
"d85f7abfc31bf755e38f6a52aaa17931c577363d"}

[commit-bot: I haz the power, 2016-11-29 02:53:50]

Description was changed from

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman
==========

to

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman
==========

[commit-bot: I haz the power, 2016-11-29 02:53:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 02:56:09]

Description was changed from

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman
==========

to

==========
DevTools: teach UISourceCodeFrame to merge messages

This patch teaches UISourceCodeFrame to display messages from both
UISourceCodes of PersistenceBinding. This is reasonable, since
there might be different "builders" which add messages to either
of the source codes.

This patch also slightly modifies the handling of decorations:
in case of persistence binding, we prefer network uiSourceCode decorations
over the fileSystem ones: it's hard to merge decorations.

This is also an imperative step towards displaying fileSystem file
by default in the editor.

BUG=649837
R=dgozman

Committed: https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d
Cr-Commit-Position: refs/heads/master@{#434847}
==========

[commit-bot: I haz the power, 2016-11-29 02:56:10]

Patchset 2 (id:??) landed as
https://crrev.com/0496be2799d97a95ace380e2e45e454f549d6b2d
Cr-Commit-Position: refs/heads/master@{#434847}