Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2513613002: Add informational messages to clarify what can be filtered on. (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel, mithro
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Add informational messages to clarify what can be filtered on. These informational messages should clarify that users can only filter on tags and dimensions. This adjusts the "float selected columns to the top" to sort those floated columns in the order they are displayed. This adds ... at the bottom of the task list to clarify that not all options are givin for sorting tags (due to memory constraints). This changes sort order a bit. "none" now sorts at the bottom (like ZZZ) which makes it less obnoxious than being in the middle. This adds internal_ip to visually see what ip addresses have been assigned. BUG=665277, 664832 Committed: https://github.com/luci/luci-py/commit/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3

Patch Set 1 #

Patch Set 2 : Tweak spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -45 lines) Patch
M appengine/swarming/ui/build/elements.html View 1 7 chunks +15 lines, -19 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-filters.html View 1 2 chunks +11 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 8 chunks +18 lines, -16 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html View 1 chunk +8 lines, -0 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html View 5 chunks +28 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-filters.html View 3 chunks +17 lines, -7 lines 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list.html View 2 chunks +8 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
kjlubick
Live at: https://2486-c9f08e9-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com Demo: https://screencast.googleplex.com/cast/NTcxMzc5MjA1OTA0NzkzNnwwNjk2ZjIxMS05NQ
4 years, 1 month ago (2016-11-17 16:32:20 UTC) #4
kjlubick
4 years, 1 month ago (2016-11-17 19:52:32 UTC) #6
stephana
On 2016/11/17 19:52:32, kjlubick wrote: lgtm
4 years, 1 month ago (2016-11-17 20:00:25 UTC) #7
KevinL
lgtm
4 years, 1 month ago (2016-11-17 20:02:14 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2511463003 Patch 1). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-17 20:02:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513613002/20001
4 years, 1 month ago (2016-11-17 20:08:17 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:11:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3

Powered by Google App Engine
This is Rietveld 408576698