Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2511463003: Move error-toast up and make server details problems easy to see (Closed)

Created:
4 years, 1 month ago by kjlubick
Modified:
4 years, 1 month ago
Reviewers:
KevinL, jcgregorio, stephana
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Move error-toast up and Give a warning if clientid is not set This makes sure all pages have an error-toast element. This allows server details problems (typically 403) easier to see and address, especially when setting up a new instance. The pages now will be bright red and easily visible if client id is not set. Again, this is useful for setting up a new instance. BUG=665442 Committed: https://github.com/luci/luci-py/commit/feb72d34696812e45df91585a1bd28162e0b7b64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -36 lines) Patch
M appengine/swarming/ui/build/elements.html View 4 chunks +5 lines, -5 lines 0 comments Download
M appengine/swarming/ui/res/imp/botlist/bot-list.html View 2 chunks +0 lines, -2 lines 0 comments Download
M appengine/swarming/ui/res/imp/botpage/bot-page.html View 2 chunks +0 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/common/swarming-app.html View 5 chunks +39 lines, -19 lines 0 comments Download
M appengine/swarming/ui/res/imp/index/swarming-index-demo.html View 1 chunk +1 line, -1 line 0 comments Download
M appengine/swarming/ui/res/imp/tasklist/task-list.html View 2 chunks +0 lines, -3 lines 0 comments Download
M appengine/swarming/ui/res/imp/taskpage/task-page.html View 2 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
kjlubick
https://screenshot.googleplex.com/hDgMzzsm6Q3
4 years, 1 month ago (2016-11-16 18:04:48 UTC) #3
kjlubick
4 years, 1 month ago (2016-11-17 19:52:18 UTC) #5
stephana
On 2016/11/17 19:52:18, kjlubick wrote: lgtm
4 years, 1 month ago (2016-11-17 19:56:52 UTC) #6
KevinL
lgtm
4 years, 1 month ago (2016-11-17 20:01:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2511463003/1
4 years, 1 month ago (2016-11-17 20:01:49 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:06:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/feb72d34696812e45df91585a1bd28162e0b7b64

Powered by Google App Engine
This is Rietveld 408576698