Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1971)

Unified Diff: appengine/swarming/ui/res/imp/tasklist/task-filters.html

Issue 2513613002: Add informational messages to clarify what can be filtered on. (Closed)
Patch Set: Tweak spacing Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/tasklist/task-filters.html
diff --git a/appengine/swarming/ui/res/imp/tasklist/task-filters.html b/appengine/swarming/ui/res/imp/tasklist/task-filters.html
index 2c880aeb3b828f035d51e75ab948fa90d5451727..e49cf7205b3b8a5f147451b04fed77e6b22e2eed 100644
--- a/appengine/swarming/ui/res/imp/tasklist/task-filters.html
+++ b/appengine/swarming/ui/res/imp/tasklist/task-filters.html
@@ -39,13 +39,12 @@
<dom-module id="task-filters">
<template>
<style is="custom-style" include="iron-flex iron-flex-alignment iron-positioning query-column-filter-style">
- .item.wide {
- max-width: 400px;
- }
- .selector.wide {
- min-width: 275px;
- }
-
+ .item.wide {
+ max-width: 400px;
+ }
+ .selector.wide {
+ min-width: 275px;
+ }
</style>
<url-param name="f"
@@ -121,6 +120,12 @@
</iron-icon>
</div>
</template>
+ <template is="dom-if" if="[[_secondaryItems.length]]">
+ <div class="pointable item" title="There may be more valid options than just the ones shown.">...</div>
+ </template>
+ <template is="dom-if" if="[[_showTagMessage(_primarySelected,_secondaryItems.length)]]">
+ <div class="item">Only tags can be used for filtering. <i>"[[_primarySelected]]"</i> is informational only.</div>
+ </template>
</div>
<div class="selector side-by-side"
@@ -250,7 +255,12 @@
}
}
return params;
+ },
+
+ _showTagMessage: function(primarySelected, selectedItems) {
+ return primarySelected && primarySelected !== "name" && !selectedItems;
}
+
});
})();
</script>

Powered by Google App Engine
This is Rietveld 408576698