Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2283)

Unified Diff: appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html

Issue 2513613002: Add informational messages to clarify what can be filtered on. (Closed)
Patch Set: Tweak spacing Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
diff --git a/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html b/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
index 62370ae9ebee58a522bae515de56657e996deba9..6189fe5446b2df13ac067499f061d9ac5a29bc14 100644
--- a/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
+++ b/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
@@ -154,7 +154,15 @@
}
// Default to a natural compare of the columns.
var aCol = this._column(this._sort.name, a);
+ if (aCol === "none"){
+ // put "none" at the bottom of the sort order
+ aCol = "ZZZ";
+ }
var bCol = this._column(this._sort.name, b);
+ if (bCol === "none"){
+ // put "none" at the bottom of the sort order
+ bCol = "ZZZ";
+ }
return dir * swarming.naturalCompare(aCol, bCol);
},

Powered by Google App Engine
This is Rietveld 408576698