Remove offscreen compositor contexts.

Remove offscreen compositor contexts.

After https://codereview.chromium.org/250083002/ cc no longer uses an
offscreen context for ganesh filters. Instead using the main onscreen
context.

So, delete the code to create offscreen contexts for the compositor.

R=abarth@chromium.org, boliu@chromium.org, enne@chromium.org, piman@chromium.org, enne, piman
BUG=366132, 366130
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265974

[danakj, 2014-04-23 22:38:12]

enne: please review cc
piman: please review everything else
boliu: please review android webview (DeferredInit) changes
abarth: mojo/ OWNERS

[enne (OOO), 2014-04-23 22:41:20]

cc: lgtm with a side of <333

[abarth-chromium, 2014-04-23 22:51:35]

mojo/ LGTM

[piman, 2014-04-24 00:13:59]

Wow
                        awesome
              much delete
   very simplify
                           lgtm

https://codereview.chromium.org/251343002/diff/1/content/renderer/render_thre...
File content/renderer/render_thread_impl.cc (left):

https://codereview.chromium.org/251343002/diff/1/content/renderer/render_thre...
content/renderer/render_thread_impl.cc:571:
offscreen_compositor_contexts_->set_leak_on_destroy();
nit: Is there anything calling set_leak_on_destroy() any more? Can we remove it?

[boliu, 2014-04-24 00:28:57]

synchronous_compositor and DeferredInit lgtm

https://codereview.chromium.org/251343002/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (left):

https://codereview.chromium.org/251343002/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:1935: bool success = true;
omg, this is awesome

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
File content/browser/android/in_process/synchronous_compositor_factory_impl.h
(right):

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
content/browser/android/in_process/synchronous_compositor_factory_impl.h:48:
GetOffscreenContextProviderForCompositorThread() OVERRIDE;
Can remove virtual and OVERRIDE, otherwise clang will complain.

[danakj, 2014-04-24 15:01:31]

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
File content/browser/android/in_process/synchronous_compositor_factory_impl.h
(right):

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
content/browser/android/in_process/synchronous_compositor_factory_impl.h:48:
GetOffscreenContextProviderForCompositorThread() OVERRIDE;
On 2014/04/24 00:28:57, boliu wrote:
> Can remove virtual and OVERRIDE, otherwise clang will complain.

This method is still in the SynchronousCompositorFactory interface, so I think
it needs to stay.

https://codereview.chromium.org/251343002/diff/1/content/renderer/render_thre...
File content/renderer/render_thread_impl.cc (left):

https://codereview.chromium.org/251343002/diff/1/content/renderer/render_thre...
content/renderer/render_thread_impl.cc:571:
offscreen_compositor_contexts_->set_leak_on_destroy();
On 2014/04/24 00:14:00, piman wrote:
> nit: Is there anything calling set_leak_on_destroy() any more? Can we remove
it?

Done.

[danakj, 2014-04-24 15:02:41]

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
File content/browser/android/in_process/synchronous_compositor_factory_impl.h
(right):

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
content/browser/android/in_process/synchronous_compositor_factory_impl.h:48:
GetOffscreenContextProviderForCompositorThread() OVERRIDE;
On 2014/04/24 15:01:32, danakj wrote:
> On 2014/04/24 00:28:57, boliu wrote:
> > Can remove virtual and OVERRIDE, otherwise clang will complain.
> 
> This method is still in the SynchronousCompositorFactory interface, so I think
> it needs to stay.

But it looks like I could remoev it from the interface

[danakj, 2014-04-24 15:04:06]

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
File content/browser/android/in_process/synchronous_compositor_factory_impl.h
(right):

https://codereview.chromium.org/251343002/diff/1/content/browser/android/in_p...
content/browser/android/in_process/synchronous_compositor_factory_impl.h:48:
GetOffscreenContextProviderForCompositorThread() OVERRIDE;
On 2014/04/24 15:02:42, danakj wrote:
> On 2014/04/24 15:01:32, danakj wrote:
> > On 2014/04/24 00:28:57, boliu wrote:
> > > Can remove virtual and OVERRIDE, otherwise clang will complain.
> > 
> > This method is still in the SynchronousCompositorFactory interface, so I
think
> > it needs to stay.

This was me looking at my file without refreshing it after switching branches.

Done!

[danakj, 2014-04-24 15:06:12]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:07:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/251343002/80001

[commit-bot: I haz the power, 2014-04-24 15:07:08]

Failed to request the patch to try. Please note that binary files are still
unsupported at the moment, this is being worked on.

Thanks for your patience.

Transient error: HTTP Error 404: Not Found

[danakj, 2014-04-24 15:07:29]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:07:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/251343002/100001

[commit-bot: I haz the power, 2014-04-24 15:18:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:18:53]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[danakj, 2014-04-24 15:20:39]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:21:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/251343002/120001

[commit-bot: I haz the power, 2014-04-24 15:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 15:26:34]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[danakj, 2014-04-24 16:36:34]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-04-24 16:37:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/251343002/140001

[danakj, 2014-04-24 19:49:03]

Committed patchset #5 manually as r265974 (presubmit successful).

[commit-bot: I haz the power, 2014-04-24 21:07:15]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel