Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2512623002: Add connection option kSMHL indicating supporting SETTINGS_MAX_HEADER_LIST_SIZE. SETTINGS_MAX_HEADE… (Closed)

Created:
4 years, 1 month ago by mpw
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add connection option kSMHL indicating supporting SETTINGS_MAX_HEADER_LIST_SIZE. SETTINGS_MAX_HEADER_LIST_SIZE is sent if kSMHL is received, protected by ENABLED FLAGS_quic_send_max_header_list_size. No behavior change is expected until Chrome starts sending this new connection option. Merge internal change: 138466879 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -25 lines) Patch
M net/quic/core/crypto/crypto_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_client_session_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_config.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/core/quic_config.cc View 6 chunks +19 lines, -1 line 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +58 lines, -10 lines 0 comments Download

Depends on Patchset:

Issue 2511643002 Patch 2

Messages

Total messages: 3 (1 generated)
mpw
4 years, 1 month ago (2016-11-17 04:58:19 UTC) #1
mpw
4 years, 1 month ago (2016-11-17 18:19:19 UTC) #2 
FYI, this patch caused various test failures, and given that it may be rolled
back internally, I am going to skip it for now.

Powered by Google App Engine
This is Rietveld 408576698