Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: net/quic/core/quic_crypto_server_stream_test.cc

Issue 2512623002: Add connection option kSMHL indicating supporting SETTINGS_MAX_HEADER_LIST_SIZE. SETTINGS_MAX_HEADE… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_config.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_crypto_server_stream_test.cc
diff --git a/net/quic/core/quic_crypto_server_stream_test.cc b/net/quic/core/quic_crypto_server_stream_test.cc
index b5ed5bf53f863aa7b237673d39daf2ef00369912..b0a159bc35f8f095acaf013dc3b1472c012dfb46 100644
--- a/net/quic/core/quic_crypto_server_stream_test.cc
+++ b/net/quic/core/quic_crypto_server_stream_test.cc
@@ -472,6 +472,12 @@ TEST_P(QuicCryptoServerStreamTest, OnlySendSCUPAfterHandshakeComplete) {
}
TEST_P(QuicCryptoServerStreamTest, SendSCUPAfterHandshakeComplete) {
+ // Do not send MAX_HEADER_LIST_SIZE SETTING frame.
+ // TODO(fayang): This SETTING frame cannot be decrypted and
+ // CryptoTestUtils::MovePackets stops processing parsing following packets.
+ // Actually, crypto stream test should use QuicSession instead of
+ // QuicSpdySession (b/32366134).
+ FLAGS_quic_send_max_header_list_size = false;
Initialize();
InitializeFakeClient(/* supports_stateless_rejects= */ false);
« no previous file with comments | « net/quic/core/quic_config.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698