Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: net/quic/core/quic_headers_stream_test.cc

Issue 2512623002: Add connection option kSMHL indicating supporting SETTINGS_MAX_HEADER_LIST_SIZE. SETTINGS_MAX_HEADE… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_headers_stream.cc ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_headers_stream_test.cc
diff --git a/net/quic/core/quic_headers_stream_test.cc b/net/quic/core/quic_headers_stream_test.cc
index 236bc6460d12039e148a0dc29013c24a5706e985..346cd16beb3588df1786769de297713727d77d19 100644
--- a/net/quic/core/quic_headers_stream_test.cc
+++ b/net/quic/core/quic_headers_stream_test.cc
@@ -744,10 +744,13 @@ TEST_P(QuicHeadersStreamTest, ProcessSpdySettingsFrame) {
TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameSupportedFields) {
FLAGS_quic_respect_http2_settings_frame = true;
+ FLAGS_quic_send_max_header_list_size = true;
const uint32_t kTestHeaderTableSize = 1000;
SpdySettingsIR data;
- // Respect supported settings frames SETTINGS_HEADER_TABLE_SIZE.
+ // Respect supported settings frames SETTINGS_HEADER_TABLE_SIZE,
+ // SETTINGS_MAX_HEADER_LIST_SIZE.
data.AddSetting(SETTINGS_HEADER_TABLE_SIZE, true, true, kTestHeaderTableSize);
+ data.AddSetting(SETTINGS_MAX_HEADER_LIST_SIZE, true, true, 2000);
SpdySerializedFrame frame(framer_->SerializeFrame(data));
stream_frame_.data_buffer = frame.data();
stream_frame_.data_length = frame.size();
@@ -759,11 +762,11 @@ TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameSupportedFields) {
TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameUnsupportedFields) {
FLAGS_quic_respect_http2_settings_frame = true;
+ FLAGS_quic_send_max_header_list_size = true;
SpdySettingsIR data;
- // Does not support SETTINGS_MAX_HEADER_LIST_SIZE,
- // SETTINGS_MAX_CONCURRENT_STREAMS, SETTINGS_INITIAL_WINDOW_SIZE,
- // SETTINGS_ENABLE_PUSH and SETTINGS_MAX_FRAME_SIZE.
- data.AddSetting(SETTINGS_MAX_HEADER_LIST_SIZE, true, true, 2000);
+ // Does not support SETTINGS_MAX_CONCURRENT_STREAMS,
+ // SETTINGS_INITIAL_WINDOW_SIZE, SETTINGS_ENABLE_PUSH and
+ // SETTINGS_MAX_FRAME_SIZE.
data.AddSetting(SETTINGS_MAX_CONCURRENT_STREAMS, true, true, 100);
data.AddSetting(SETTINGS_INITIAL_WINDOW_SIZE, true, true, 100);
data.AddSetting(SETTINGS_ENABLE_PUSH, true, true, 1);
@@ -773,12 +776,6 @@ TEST_P(QuicHeadersStreamTest, RespectHttp2SettingsFrameUnsupportedFields) {
*connection_,
CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA,
"Unsupported field of HTTP/2 SETTINGS frame: " +
- base::IntToString(SETTINGS_MAX_HEADER_LIST_SIZE),
- _));
- EXPECT_CALL(
- *connection_,
- CloseConnection(QUIC_INVALID_HEADERS_STREAM_DATA,
- "Unsupported field of HTTP/2 SETTINGS frame: " +
base::IntToString(SETTINGS_MAX_CONCURRENT_STREAMS),
_));
EXPECT_CALL(
« no previous file with comments | « net/quic/core/quic_headers_stream.cc ('k') | net/quic/core/quic_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698