Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Side by Side Diff: net/quic/core/quic_crypto_server_stream_test.cc

Issue 2512623002: Add connection option kSMHL indicating supporting SETTINGS_MAX_HEADER_LIST_SIZE. SETTINGS_MAX_HEADE… (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/core/quic_config.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/core/quic_crypto_server_stream.h" 5 #include "net/quic/core/quic_crypto_server_stream.h"
6 6
7 #include <map> 7 #include <map>
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 465
466 TEST_P(QuicCryptoServerStreamTest, OnlySendSCUPAfterHandshakeComplete) { 466 TEST_P(QuicCryptoServerStreamTest, OnlySendSCUPAfterHandshakeComplete) {
467 // An attempt to send a SCUP before completing handshake should fail. 467 // An attempt to send a SCUP before completing handshake should fail.
468 Initialize(); 468 Initialize();
469 469
470 server_stream()->SendServerConfigUpdate(nullptr); 470 server_stream()->SendServerConfigUpdate(nullptr);
471 EXPECT_EQ(0, server_stream()->NumServerConfigUpdateMessagesSent()); 471 EXPECT_EQ(0, server_stream()->NumServerConfigUpdateMessagesSent());
472 } 472 }
473 473
474 TEST_P(QuicCryptoServerStreamTest, SendSCUPAfterHandshakeComplete) { 474 TEST_P(QuicCryptoServerStreamTest, SendSCUPAfterHandshakeComplete) {
475 // Do not send MAX_HEADER_LIST_SIZE SETTING frame.
476 // TODO(fayang): This SETTING frame cannot be decrypted and
477 // CryptoTestUtils::MovePackets stops processing parsing following packets.
478 // Actually, crypto stream test should use QuicSession instead of
479 // QuicSpdySession (b/32366134).
480 FLAGS_quic_send_max_header_list_size = false;
475 Initialize(); 481 Initialize();
476 482
477 InitializeFakeClient(/* supports_stateless_rejects= */ false); 483 InitializeFakeClient(/* supports_stateless_rejects= */ false);
478 484
479 // Do a first handshake in order to prime the client config with the server's 485 // Do a first handshake in order to prime the client config with the server's
480 // information. 486 // information.
481 AdvanceHandshakeWithFakeClient(); 487 AdvanceHandshakeWithFakeClient();
482 488
483 // Now do another handshake, with the blocking SHLO connection option. 489 // Now do another handshake, with the blocking SHLO connection option.
484 InitializeServer(); 490 InitializeServer();
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 // Regression test for b/31521252, in which a crash would happen here. 625 // Regression test for b/31521252, in which a crash would happen here.
620 AdvanceHandshakeWithFakeClient(); 626 AdvanceHandshakeWithFakeClient();
621 EXPECT_FALSE(server_stream()->encryption_established()); 627 EXPECT_FALSE(server_stream()->encryption_established());
622 EXPECT_FALSE(server_stream()->handshake_confirmed()); 628 EXPECT_FALSE(server_stream()->handshake_confirmed());
623 } 629 }
624 630
625 } // namespace 631 } // namespace
626 632
627 } // namespace test 633 } // namespace test
628 } // namespace net 634 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/core/quic_config.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698