Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2512613003:
remove unnecessary paper-item dependency from site_details. (Closed)
|
Created:
4 years, 1 month ago by scottchen Modified:
4 years, 1 month ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionremove unnecessary paper-item dependency from site_details.
We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both.
BUG=603976
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/2507bc013bac421e3775d7119322aced956b633a
Cr-Commit-Position: refs/heads/master@{#433278}
Patch Set 1 #
Total comments: 8
Patch Set 2 : use dom-if instead of hidden, and fix tests to accomodate #
Total comments: 2
Messages
Total messages: 30 (20 generated)
Description was changed from ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG= ========== to ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG=603976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
scottchen@chromium.org changed reviewers: + dpapad@chromium.org
https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:50: <div class="list-item" id="storage"> We still need the hidden$="[[!storedData_]] part, no?
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:50: <div class="list-item" id="storage"> On 2016/11/17 23:36:58, dpapad wrote: > We still need the hidden$="[[!storedData_]] part, no? An ancestor element has the exact same hidden condition, so I think it's redundant and we can remove it - if the ancestor hides on [[!storedData_]], this element will be hidden regardless.
LGTM. https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:6: <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html"> Let's remove this dependency. https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:50: <div class="list-item" id="storage"> On 2016/11/17 at 23:55:50, scottchen wrote: > On 2016/11/17 23:36:58, dpapad wrote: > > We still need the hidden$="[[!storedData_]] part, no? > > An ancestor element has the exact same hidden condition, so I think it's redundant and we can remove it - if the ancestor hides on [[!storedData_]], this element will be hidden regardless. I see. Good catch.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:45: <div id="usage" hidden$="[[!storedData_]]"> can we just make this a dom-if instead then?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_details.html (right): https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:6: <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html"> On 2016/11/17 23:59:28, dpapad wrote: > Let's remove this dependency. Done. https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:45: <div id="usage" hidden$="[[!storedData_]]"> On 2016/11/18 00:06:16, Dan Beam wrote: > can we just make this a dom-if instead then? Done. https://codereview.chromium.org/2512613003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_details.html:50: <div class="list-item" id="storage"> On 2016/11/17 23:59:28, dpapad wrote: > On 2016/11/17 at 23:55:50, scottchen wrote: > > On 2016/11/17 23:36:58, dpapad wrote: > > > We still need the hidden$="[[!storedData_]] part, no? > > > > An ancestor element has the exact same hidden condition, so I think it's > redundant and we can remove it - if the ancestor hides on [[!storedData_]], this > element will be hidden regardless. > > I see. Good catch. Done.
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by scottchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2512613003/diff/20001/chrome/test/data/webui/... File chrome/test/data/webui/settings/site_details_tests.js (right): https://codereview.chromium.org/2512613003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_tests.js:146: //expect usage to not be rendered I don't think this comment adds much https://codereview.chromium.org/2512613003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/settings/site_details_tests.js:210: //expect usage to be rendered // Expect usage to be rendered.
The CQ bit was checked by scottchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2512613003/#ps20001 (title: "use dom-if instead of hidden, and fix tests to accomodate")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG=603976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG=603976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG=603976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== remove unnecessary paper-item dependency from site_details. We're trying to remove all paper-item dependency for performance reasons, and a div with list-item class can achieve the desired visual effects and seems more suitable. I also removed the hidden attribute because its parent element has the exact same hidden condition, so seems redundant to have both. BUG=603976 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2507bc013bac421e3775d7119322aced956b633a Cr-Commit-Position: refs/heads/master@{#433278} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2507bc013bac421e3775d7119322aced956b633a Cr-Commit-Position: refs/heads/master@{#433278} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
