Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8826)

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 2512613003: remove unnecessary paper-item dependency from site_details. (Closed)
Patch Set: use dom-if instead of hidden, and fix tests to accomodate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/site_settings/site_details.html
diff --git a/chrome/browser/resources/settings/site_settings/site_details.html b/chrome/browser/resources/settings/site_settings/site_details.html
index 9a93225392e5e34e3d04b6f15b6fa215a5e98f74..abaff2edbe6e2e4cd25fe438b74fc22b327a8ebd 100644
--- a/chrome/browser/resources/settings/site_settings/site_details.html
+++ b/chrome/browser/resources/settings/site_settings/site_details.html
@@ -41,19 +41,21 @@
</div>
<div class="middle">[[site.originForDisplay]]</div>
</div>
- <div id="usage" hidden$="[[!storedData_]]">
- <div class="settings-box first">
- <h2>$i18n{siteSettingsUsage}</h2>
+ <template is="dom-if" if="[[storedData_]]">
+ <div id="usage">
+ <div class="settings-box first">
+ <h2>$i18n{siteSettingsUsage}</h2>
+ </div>
+ <div class="list-frame">
+ <div class="list-item" id="storage">
+ <div class="flex">[[storedData_]]</div>
+ <paper-icon-button icon="cr:delete"
+ on-tap="onConfirmClearStorage_"
+ alt="$i18n{siteSettingsDelete}"></paper-icon-button>
+ </div>
+ </div>
</div>
- <div class="list-frame">
- <paper-item id="storage" hidden$="[[!storedData_]]">
- <div class="flex">[[storedData_]]</div>
- <paper-icon-button icon="cr:delete"
- on-tap="onConfirmClearStorage_"
- alt="$i18n{siteSettingsDelete}"></paper-icon-button>
- </paper-item>
- </div>
- </div>
+ </template>
<div class="settings-box first">
<h2>$i18n{siteSettingsPermissions}</h2>
</div>

Powered by Google App Engine
This is Rietveld 408576698