remove unnecessary paper-item dependency from site_details.

chrome/browser/resources/settings/site_settings/site_details.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/icons.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">

[dpapad, 2016/11/17 23:59:28]

Let's remove this dependency.

[scottchen, 2016/11/18 02:09:43]

Done.

 <link rel="import" href="/route.html">
 <link rel="import" href="/settings_shared_css.html">
 <link rel="import" href="/site_settings/constants.html">
 <link rel="import" href="/site_settings/site_details_permission.html">
 <link rel="import" href="/site_settings/site_settings_behavior.html">
 <link rel="import" href="/site_settings/website_usage_private_api.html">
 
 <dom-module id="site-details">
   <template>
     <style include="settings-shared">
@@ skipping 18 matching lines @@
         </paper-button>
       </div>
     </dialog>
 
     <div class="settings-box first">
       <div class="favicon-image"
           style$="[[computeSiteIcon(site.originForDisplay)]]">
       </div>
       <div class="middle">[[site.originForDisplay]]</div>
     </div>
     <div id="usage" hidden$="[[!storedData_]]">

[Dan Beam, 2016/11/18 00:06:16]

can we just make this a dom-if instead then?

[scottchen, 2016/11/18 02:09:43]

Done.

       <div class="settings-box first">
         <h2>$i18n{siteSettingsUsage}</h2>
       </div>
       <div class="list-frame">
-        <paper-item id="storage" hidden$="[[!storedData_]]">
+        <div class="list-item" id="storage">

[dpapad, 2016/11/17 23:36:58]

We still need the hidden$="[[!storedData_]] part, no?

[scottchen, 2016/11/17 23:55:50]

An ancestor element has the exact same hidden condition, so I think it's
redundant and we can remove it - if the ancestor hides on [[!storedData_]], this
element will be hidden regardless.

[dpapad, 2016/11/17 23:59:28]

I see. Good catch.

[scottchen, 2016/11/18 02:09:43]

Done.

           <div class="flex">[[storedData_]]</div>
           <paper-icon-button icon="cr:delete"
               on-tap="onConfirmClearStorage_"
               alt="$i18n{siteSettingsDelete}"></paper-icon-button>
-        </paper-item>
+        </div>
       </div>
     </div>
     <div class="settings-box first">
       <h2>$i18n{siteSettingsPermissions}</h2>
     </div>
     <div class="list-frame">
       <site-details-permission category="{{ContentSettingsTypes.COOKIES}}"
           icon="settings:cookie" id="cookies" label="$i18n{siteSettingsCookies}"
           site="[[site]]">
       </site-details-permission>
@@ skipping 49 matching lines @@
         $i18n{siteSettingsClearAndReset}
       </div>
     </div>
     <website-usage-private-api id="usageApi"
         website-data-usage="{{storedData_}}"
         website-storage-type="{{storageType_}}">
     </website-usage-private-api>
   </template>
   <script src="site_details.js"></script>
 </dom-module>