Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/resources/settings/site_settings/site_details.html

Issue 2512613003: remove unnecessary paper-item dependency from site_details. (Closed)
Patch Set: use dom-if instead of hidden, and fix tests to accomodate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 2 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
3 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 3 <link rel="import" href="chrome://resources/cr_elements/icons.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 <link rel="import" href="/route.html"> 6 <link rel="import" href="/route.html">
7 <link rel="import" href="/settings_shared_css.html"> 7 <link rel="import" href="/settings_shared_css.html">
8 <link rel="import" href="/site_settings/constants.html"> 8 <link rel="import" href="/site_settings/constants.html">
9 <link rel="import" href="/site_settings/site_details_permission.html"> 9 <link rel="import" href="/site_settings/site_details_permission.html">
10 <link rel="import" href="/site_settings/site_settings_behavior.html"> 10 <link rel="import" href="/site_settings/site_settings_behavior.html">
(...skipping 23 matching lines...) Expand all
34 </paper-button> 34 </paper-button>
35 </div> 35 </div>
36 </dialog> 36 </dialog>
37 37
38 <div class="settings-box first"> 38 <div class="settings-box first">
39 <div class="favicon-image" 39 <div class="favicon-image"
40 style$="[[computeSiteIcon(site.originForDisplay)]]"> 40 style$="[[computeSiteIcon(site.originForDisplay)]]">
41 </div> 41 </div>
42 <div class="middle">[[site.originForDisplay]]</div> 42 <div class="middle">[[site.originForDisplay]]</div>
43 </div> 43 </div>
44 <div id="usage" hidden$="[[!storedData_]]"> 44 <template is="dom-if" if="[[storedData_]]">
45 <div class="settings-box first"> 45 <div id="usage">
46 <h2>$i18n{siteSettingsUsage}</h2> 46 <div class="settings-box first">
47 <h2>$i18n{siteSettingsUsage}</h2>
48 </div>
49 <div class="list-frame">
50 <div class="list-item" id="storage">
51 <div class="flex">[[storedData_]]</div>
52 <paper-icon-button icon="cr:delete"
53 on-tap="onConfirmClearStorage_"
54 alt="$i18n{siteSettingsDelete}"></paper-icon-button>
55 </div>
56 </div>
47 </div> 57 </div>
48 <div class="list-frame"> 58 </template>
49 <paper-item id="storage" hidden$="[[!storedData_]]">
50 <div class="flex">[[storedData_]]</div>
51 <paper-icon-button icon="cr:delete"
52 on-tap="onConfirmClearStorage_"
53 alt="$i18n{siteSettingsDelete}"></paper-icon-button>
54 </paper-item>
55 </div>
56 </div>
57 <div class="settings-box first"> 59 <div class="settings-box first">
58 <h2>$i18n{siteSettingsPermissions}</h2> 60 <h2>$i18n{siteSettingsPermissions}</h2>
59 </div> 61 </div>
60 <div class="list-frame"> 62 <div class="list-frame">
61 <site-details-permission category="{{ContentSettingsTypes.COOKIES}}" 63 <site-details-permission category="{{ContentSettingsTypes.COOKIES}}"
62 icon="settings:cookie" id="cookies" label="$i18n{siteSettingsCookies}" 64 icon="settings:cookie" id="cookies" label="$i18n{siteSettingsCookies}"
63 site="[[site]]"> 65 site="[[site]]">
64 </site-details-permission> 66 </site-details-permission>
65 <site-details-permission category="{{ContentSettingsTypes.GEOLOCATION}}" 67 <site-details-permission category="{{ContentSettingsTypes.GEOLOCATION}}"
66 icon="settings:location-on" id="geolocation" 68 icon="settings:location-on" id="geolocation"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 $i18n{siteSettingsClearAndReset} 116 $i18n{siteSettingsClearAndReset}
115 </div> 117 </div>
116 </div> 118 </div>
117 <website-usage-private-api id="usageApi" 119 <website-usage-private-api id="usageApi"
118 website-data-usage="{{storedData_}}" 120 website-data-usage="{{storedData_}}"
119 website-storage-type="{{storageType_}}"> 121 website-storage-type="{{storageType_}}">
120 </website-usage-private-api> 122 </website-usage-private-api>
121 </template> 123 </template>
122 <script src="site_details.js"></script> 124 <script src="site_details.js"></script>
123 </dom-module> 125 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698