Rename "updateICE" to "setConfiguration", everywhere except in Blink.

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
index 79f35a22693a050135726de006be5a2fbaca6f97..8d2a60b778239fc21ed7f8f7c5dcc03e7b6753ab 100644
--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
@@ -800,7 +800,7 @@ RTCSessionDescription* RTCPeerConnection::remoteDescription() {
 
 void RTCPeerConnection::updateIce(ExecutionContext* context,
                                   const RTCConfiguration& rtcConfiguration,
-                                  const Dictionary& mediaConstraints,
+                                  const Dictionary&,
                                   ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return;
@@ -818,12 +818,11 @@ void RTCPeerConnection::updateIce(ExecutionContext* context,
     return;
   }
 
-  // Constraints are ignored.
-  bool valid = m_peerHandler->updateICE(configuration);
-  if (!valid)
-    exceptionState.throwDOMException(
-        SyntaxError,
-        "Could not update the ICE Agent with the given configuration.");
+  // TODO(deadbeef): When this changes to setConfiguration, call
+  // m_peerHandler->setConfiguration.

[hbos_chromium, 2016/11/21 09:13:04]

This will now no longer track updateIce
(RTCPeerConnectionHandler::setConfiguration doing
peer_connection_tracker_->Track[UpdateIce/SetConfiguration]) but I think that is
OK considering this always failed anyway and there is no conceivable use case
for this function as implemented, and the stats we do have are 0.

(If other reviewers mind you can simply comment out
rtc_peer_connection_handler.cc:1398 instead (replace return
native_peer_connection_->SetConfiguration with return false) and move the TODO
comment there.)

[hbos_chromium, 2016/11/21 09:17:56]

If you land as-is (up to you) take a note of this in the CL description.
Also nit: prefer to keep a 76 line length in the CL description so that git log
fits in a 80 character terminal window.

+  exceptionState.throwDOMException(
+      SyntaxError,
+      "Could not update the ICE Agent with the given configuration.");
 }
 
 ScriptPromise RTCPeerConnection::generateCertificate(