Rename "updateICE" to "setConfiguration", everywhere except in Blink.

third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 782 matching lines @@
   WebRTCSessionDescription webSessionDescription =
       m_peerHandler->remoteDescription();
   if (webSessionDescription.isNull())
     return nullptr;
 
   return RTCSessionDescription::create(webSessionDescription);
 }
 
 void RTCPeerConnection::updateIce(ExecutionContext* context,
                                   const RTCConfiguration& rtcConfiguration,
-                                  const Dictionary& mediaConstraints,
+                                  const Dictionary&,
                                   ExceptionState& exceptionState) {
   if (throwExceptionIfSignalingStateClosed(m_signalingState, exceptionState))
     return;
 
   RtcpMuxPolicy selectedRtcpMuxPolicy = RtcpMuxPolicyDefault;
   WebRTCConfiguration configuration = parseConfiguration(
       context, rtcConfiguration, exceptionState, &selectedRtcpMuxPolicy);
 
   if (exceptionState.hadException())
     return;
 
   MediaErrorState mediaErrorState;
   if (mediaErrorState.hadException()) {
     mediaErrorState.raiseException(exceptionState);
     return;
   }
 
-  // Constraints are ignored.
-  bool valid = m_peerHandler->updateICE(configuration);
-  if (!valid)
-    exceptionState.throwDOMException(
-        SyntaxError,
-        "Could not update the ICE Agent with the given configuration.");
+  // TODO(deadbeef): When this changes to setConfiguration, call
+  // m_peerHandler->setConfiguration.

[hbos_chromium, 2016/11/21 09:13:04]

This will now no longer track updateIce
(RTCPeerConnectionHandler::setConfiguration doing
peer_connection_tracker_->Track[UpdateIce/SetConfiguration]) but I think that is
OK considering this always failed anyway and there is no conceivable use case
for this function as implemented, and the stats we do have are 0.

(If other reviewers mind you can simply comment out
rtc_peer_connection_handler.cc:1398 instead (replace return
native_peer_connection_->SetConfiguration with return false) and move the TODO
comment there.)

[hbos_chromium, 2016/11/21 09:17:56]

If you land as-is (up to you) take a note of this in the CL description.
Also nit: prefer to keep a 76 line length in the CL description so that git log
fits in a 80 character terminal window.

+  exceptionState.throwDOMException(
+      SyntaxError,
+      "Could not update the ICE Agent with the given configuration.");
 }
 
 ScriptPromise RTCPeerConnection::generateCertificate(
     ScriptState* scriptState,
     const AlgorithmIdentifier& keygenAlgorithm,
     ExceptionState& exceptionState) {
   // Normalize |keygenAlgorithm| with WebCrypto, making sure it is a recognized
   // AlgorithmIdentifier.
   WebCryptoAlgorithm cryptoAlgorithm;
   AlgorithmError error;
@@ skipping 642 matching lines @@
 DEFINE_TRACE(RTCPeerConnection) {
   visitor->trace(m_localStreams);
   visitor->trace(m_remoteStreams);
   visitor->trace(m_dispatchScheduledEventRunner);
   visitor->trace(m_scheduledEvents);
   EventTargetWithInlineData::trace(visitor);
   ActiveDOMObject::trace(visitor);
 }
 
 }  // namespace blink