[inspector] gracefully handle stack overflows in the inspector.

[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654
Review-Url: https://codereview.chromium.org/2510093002
Cr-Original-Commit-Position: refs/heads/master@{#41802}
Committed: https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc914961735b1e
Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41807}
Committed: https://chromium.googlesource.com/v8/v8/+/d5566b9e77c61add067f96e16ef5391b3f1dc9ae

[jgruber, 2016-11-17 14:33:19]

Thanks, lgtm.

https://codereview.chromium.org/2510093002/diff/1/test/debugger/regress/regre...
File test/debugger/regress/regress-2318.js (right):

https://codereview.chromium.org/2510093002/diff/1/test/debugger/regress/regre...
test/debugger/regress/regress-2318.js:28: // Flags: --expose-debug-as debug
--stack-size=70
Please remove --expose-debug-as debug.

FYI: I have a script that automates test migration, maybe it'll be useful to you
when you do the dbc tests.

[kozy, 2016-11-17 16:36:25]

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
File src/inspector/java-script-call-frame.cc (right):

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
src/inspector/java-script-call-frame.cc:94: v8::MaybeLocal<v8::Value>
JavaScriptCallFrame::details() const {
Can we return v8::MaybeLocal<v8::Object> and check that func->Call returns
v8::Object here?

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
src/inspector/java-script-call-frame.cc:119: v8::TryCatch try_catch;
We have try_catch in V8DebuggerAgentImpl::evaluateOnCalLFrame function (in
InjectedScript::CallFrameScope) and report caught value via protocol. Do we
really need try catch here? If yes then we need to report exception to call
site, otherwise we can continue catch this exception their.

[Yang, 2016-12-12 12:23:20]

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
File src/inspector/java-script-call-frame.cc (right):

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
src/inspector/java-script-call-frame.cc:94: v8::MaybeLocal<v8::Value>
JavaScriptCallFrame::details() const {
On 2016/11/17 16:36:25, kozyatinskiy wrote:
> Can we return v8::MaybeLocal<v8::Object> and check that func->Call returns

Removed.

https://codereview.chromium.org/2510093002/diff/1/src/inspector/java-script-c...
src/inspector/java-script-call-frame.cc:119: v8::TryCatch try_catch;
On 2016/11/17 16:36:25, kozyatinskiy wrote:
> We have try_catch in V8DebuggerAgentImpl::evaluateOnCalLFrame function (in
> InjectedScript::CallFrameScope) and report caught value via protocol. Do we
> really need try catch here? If yes then we need to report exception to call
> site, otherwise we can continue catch this exception their.

Done.

[Yang, 2016-12-12 12:23:24]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 12:23:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 12:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 12:26:57]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14035)

[kozy, 2016-12-14 16:06:55]

lgtm

[Yang, 2016-12-14 16:12:38]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-14 16:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps60001
(title: "fix compile")

[commit-bot: I haz the power, 2016-12-14 16:12:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 16:14:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 16:14:17]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[Yang, 2016-12-16 12:08:32]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-16 12:08:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps80001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-16 12:08:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 12:12:26]

Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14352)

[Yang, 2016-12-16 12:29:51]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-16 12:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps100001
(title: "fix")

[commit-bot: I haz the power, 2016-12-16 12:29:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 12:50:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 12:50:21]

Try jobs failed on following builders:
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17930)
  v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)

[Yang, 2016-12-16 13:17:25]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-16 13:17:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps120001
(title: "printf")

[commit-bot: I haz the power, 2016-12-16 13:17:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 13:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:20:07]

Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Yang, 2016-12-16 13:35:03]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:35:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 13:39:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:39:44]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14365)

[Yang, 2016-12-16 13:42:46]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 14:17:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 14:17:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/17978)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Yang, 2016-12-19 08:35:07]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 08:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 08:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 08:58:21]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18040)
  v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)

[Yang, 2016-12-19 09:05:03]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 09:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-19 09:41:18]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-19 09:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps220001
(title: "remove printf")

[commit-bot: I haz the power, 2016-12-19 09:41:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 11:19:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 11:20:01]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[Yang, 2016-12-19 11:56:26]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-19 11:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps240001
(title: "narrow down")

[commit-bot: I haz the power, 2016-12-19 11:56:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 12:24:58]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1482148586687520,
"parent_rev": "1c1465f12483354daf4400d4080465a6bef7b693", "commit_rev":
"3ab3b6261a4299d14bdc109f0abc914961735b1e"}

[commit-bot: I haz the power, 2016-12-19 12:25:01]

Description was changed from

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654
==========

to

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654

Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41802}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...
==========

[commit-bot: I haz the power, 2016-12-19 12:25:02]

Committed patchset #13 (id:240001) as
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...

[Yang, 2016-12-19 13:27:59]

A revert of this CL (patchset #13 id:240001) has been created in
https://codereview.chromium.org/2583173002/ by yangguo@chromium.org.

The reason for reverting is: asan failure:
https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1004....

[Yang, 2016-12-19 13:30:05]

Description was changed from

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654

Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41802}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...
==========

to

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654

Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41802}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...
==========

[Yang, 2016-12-19 13:32:18]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 13:32:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 13:57:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 13:57:13]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-12-19 14:06:10]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-19 14:06:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2510093002/#ps260001
(title: "fix asan")

[commit-bot: I haz the power, 2016-12-19 14:06:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 14:07:56]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1482156370014110,
"parent_rev": "2c2d0e5036950b15ca560f13ea0131cb2d52e900", "commit_rev":
"d5566b9e77c61add067f96e16ef5391b3f1dc9ae"}

[commit-bot: I haz the power, 2016-12-19 14:08:00]

Description was changed from

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654

Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41802}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...
==========

to

==========
[inspector] gracefully handle stack overflows in the inspector.

Hopefully we can avoid going through JS at all, so we can avoid this issue.

R=jgruber@chromium.org, kozyatinskiy@chromium.org
BUG=v8:5654

Review-Url: https://codereview.chromium.org/2510093002
Cr-Original-Commit-Position: refs/heads/master@{#41802}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab3b6261a4299d14bdc109f0abc9149617...
Review-Url: https://codereview.chromium.org/2510093002
Cr-Commit-Position: refs/heads/master@{#41807}
Committed:
https://chromium.googlesource.com/v8/v8/+/d5566b9e77c61add067f96e16ef5391b3f1...
==========

[commit-bot: I haz the power, 2016-12-19 14:08:01]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/v8/v8/+/d5566b9e77c61add067f96e16ef5391b3f1...