[inspector] gracefully handle stack overflows in the inspector.

src/inspector/java-script-call-frame.cc

 /*
  * Copyright (c) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 73 matching lines @@
   v8::Local<v8::Object> callFrame =
       v8::Local<v8::Object>::New(m_isolate, m_callFrame);
   v8::Local<v8::Value> result;
   if (!callFrame->Get(context, toV8StringInternalized(m_isolate, "isAtReturn"))
            .ToLocal(&result) ||
       !result->IsBoolean())
     return false;
   return result.As<v8::Boolean>()->BooleanValue(context).FromMaybe(false);
 }
 
-v8::Local<v8::Object> JavaScriptCallFrame::details() const {
+v8::MaybeLocal<v8::Value> JavaScriptCallFrame::details() const {

[kozy, 2016/11/17 16:36:25]

Can we return v8::MaybeLocal<v8::Object> and check that func->Call returns
v8::Object here?

[Yang, 2016/12/12 12:23:20]

Removed.

   v8::MicrotasksScope microtasks(m_isolate,
                                  v8::MicrotasksScope::kDoNotRunMicrotasks);
   v8::Local<v8::Context> context =
       v8::Local<v8::Context>::New(m_isolate, m_debuggerContext);
   v8::Local<v8::Object> callFrame =
       v8::Local<v8::Object>::New(m_isolate, m_callFrame);
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(
       callFrame->Get(context, toV8StringInternalized(m_isolate, "details"))
           .ToLocalChecked());
-  return v8::Local<v8::Object>::Cast(
-      func->Call(context, callFrame, 0, nullptr).ToLocalChecked());
+  v8::TryCatch try_catch;
+  return func->Call(context, callFrame, 0, nullptr);
 }
 
 v8::MaybeLocal<v8::Value> JavaScriptCallFrame::evaluate(
     v8::Local<v8::Value> expression) {
   v8::MicrotasksScope microtasks(m_isolate,
                                  v8::MicrotasksScope::kRunMicrotasks);
   v8::Local<v8::Context> context =
       v8::Local<v8::Context>::New(m_isolate, m_debuggerContext);
   v8::Local<v8::Object> callFrame =
       v8::Local<v8::Object>::New(m_isolate, m_callFrame);
   v8::Local<v8::Function> evalFunction = v8::Local<v8::Function>::Cast(
       callFrame->Get(context, toV8StringInternalized(m_isolate, "evaluate"))
           .ToLocalChecked());
+  v8::TryCatch try_catch;

[kozy, 2016/11/17 16:36:25]

We have try_catch in V8DebuggerAgentImpl::evaluateOnCalLFrame function (in
InjectedScript::CallFrameScope) and report caught value via protocol. Do we
really need try catch here? If yes then we need to report exception to call
site, otherwise we can continue catch this exception their.

[Yang, 2016/12/12 12:23:20]

Done.

   return evalFunction->Call(context, callFrame, 1, &expression);
 }
 
 v8::MaybeLocal<v8::Value> JavaScriptCallFrame::restart() {
   v8::MicrotasksScope microtasks(m_isolate,
                                  v8::MicrotasksScope::kDoNotRunMicrotasks);
   v8::Local<v8::Context> context =
       v8::Local<v8::Context>::New(m_isolate, m_debuggerContext);
   v8::Local<v8::Object> callFrame =
       v8::Local<v8::Object>::New(m_isolate, m_callFrame);
   v8::Local<v8::Function> restartFunction = v8::Local<v8::Function>::Cast(
       callFrame->Get(context, toV8StringInternalized(m_isolate, "restart"))
           .ToLocalChecked());
+  v8::TryCatch try_catch;
   v8::DebugInterface::SetLiveEditEnabled(m_isolate, true);
   v8::MaybeLocal<v8::Value> result = restartFunction->Call(
       m_debuggerContext.Get(m_isolate), callFrame, 0, nullptr);
   v8::DebugInterface::SetLiveEditEnabled(m_isolate, false);
   return result;
 }
 
 v8::MaybeLocal<v8::Value> JavaScriptCallFrame::setVariableValue(
     int scopeNumber, v8::Local<v8::Value> variableName,
     v8::Local<v8::Value> newValue) {
   v8::MicrotasksScope microtasks(m_isolate,
                                  v8::MicrotasksScope::kDoNotRunMicrotasks);
   v8::Local<v8::Context> context =
       v8::Local<v8::Context>::New(m_isolate, m_debuggerContext);
   v8::Local<v8::Object> callFrame =
       v8::Local<v8::Object>::New(m_isolate, m_callFrame);
   v8::Local<v8::Function> setVariableValueFunction =
       v8::Local<v8::Function>::Cast(
           callFrame
               ->Get(context,
                     toV8StringInternalized(m_isolate, "setVariableValue"))
               .ToLocalChecked());
   v8::Local<v8::Value> argv[] = {
       v8::Local<v8::Value>(v8::Integer::New(m_isolate, scopeNumber)),
       variableName, newValue};
+  v8::TryCatch try_catch;
   return setVariableValueFunction->Call(context, callFrame, arraysize(argv),
                                         argv);
 }
 
 }  // namespace v8_inspector