Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: src/d8.cc

Issue 2510093002: [inspector] gracefully handle stack overflows in the inspector. (Closed)
Patch Set: fix asan Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/java-script-call-frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index ad7d1680ecaf54eca853bd4a183f5d259b6dddcd..9c5dd0cd73ec7be83eecb9cf5242ead0845da11b 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -1931,9 +1931,8 @@ class InspectorFrontend final : public v8_inspector::V8Inspector::Channel {
"Maximum call stack size exceeded",
v8::NewStringType::kNormal)
.ToLocalChecked();
- CHECK(exception->Get(context, key)
- .ToLocalChecked()
- ->StrictEquals(expected));
+ Local<Value> value = exception->Get(context, key).ToLocalChecked();
+ CHECK(value->StrictEquals(expected));
}
#endif
}
« no previous file with comments | « no previous file | src/inspector/java-script-call-frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698