Unify the three CFWL_EventType::SelectChange classes.

Unify the three CFWL_EventType::SelectChange classes.

This CL removes the ListBox SelectChange class as it is never processed. The
other two have been unified into a single classs.

Committed: https://pdfium.googlesource.com/pdfium/+/3855f7ff0d4c5c8653fc17219bf65c4a0a95e8bb

[dsinclair, 2016-11-17 17:24:11]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-17 17:24:11]

PTAL.

[dsinclair, 2016-11-17 17:24:16]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 17:24:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-17 17:25:55]

There's red bots

[commit-bot: I haz the power, 2016-11-17 17:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 17:26:09]

Dry run: Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)
  win_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...)
  win_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_rel/bui...)

[npm, 2016-11-17 18:07:02]

Never mind the redness seems to be just patch failures

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (left):

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:568: ev.iArraySels.Add(m_iCurSel);
Is iArraySels never used, or why is this deleted?

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.cpp
File xfa/fwl/core/ifwl_listbox.cpp (left):

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.c...
xfa/fwl/core/ifwl_listbox.cpp:846: void IFWL_ListBox::ProcessSelChanged() {
Can we delete this method altogether?

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.c...
xfa/fwl/core/ifwl_listbox.cpp:1101: void IFWL_ListBox::DispatchSelChangedEv() {
Ditto

[dsinclair, 2016-11-17 18:13:19]

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_combobox.cpp
File xfa/fwl/core/ifwl_combobox.cpp (left):

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_combobox....
xfa/fwl/core/ifwl_combobox.cpp:568: ev.iArraySels.Add(m_iCurSel);
On 2016/11/17 18:07:02, npm wrote:
> Is iArraySels never used, or why is this deleted?

Removed from class, compiler is happy.

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.cpp
File xfa/fwl/core/ifwl_listbox.cpp (left):

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.c...
xfa/fwl/core/ifwl_listbox.cpp:846: void IFWL_ListBox::ProcessSelChanged() {
On 2016/11/17 18:07:02, npm wrote:
> Can we delete this method altogether?

Done.

https://codereview.chromium.org/2509283003/diff/1/xfa/fwl/core/ifwl_listbox.c...
xfa/fwl/core/ifwl_listbox.cpp:1101: void IFWL_ListBox::DispatchSelChangedEv() {
On 2016/11/17 18:07:02, npm wrote:
> Ditto

Done.

[npm, 2016-11-17 18:39:07]

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
File xfa/fwl/core/ifwl_listbox.cpp (left):

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
xfa/fwl/core/ifwl_listbox.cpp:857: DispatchEvent(&selEvent);
I agree with deletion of unused m_pSrcTarget and iarraySels. But we are also
assuming that DispatchEvent does nothing if it does not know the event it
receives, right? Just making sure this is right :)

[dsinclair, 2016-11-17 18:39:54]

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
File xfa/fwl/core/ifwl_listbox.cpp (left):

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
xfa/fwl/core/ifwl_listbox.cpp:857: DispatchEvent(&selEvent);
On 2016/11/17 18:39:07, npm wrote:
> I agree with deletion of unused m_pSrcTarget and iarraySels. But we are also
> assuming that DispatchEvent does nothing if it does not know the event it
> receives, right? Just making sure this is right :)


All the ones I've seen check the EventType before doing any processing.

[npm, 2016-11-17 18:45:08]

lgtm

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
File xfa/fwl/core/ifwl_listbox.cpp (left):

https://codereview.chromium.org/2509283003/diff/40001/xfa/fwl/core/ifwl_listb...
xfa/fwl/core/ifwl_listbox.cpp:857: DispatchEvent(&selEvent);
On 2016/11/17 18:39:54, dsinclair wrote:
> On 2016/11/17 18:39:07, npm wrote:
> > I agree with deletion of unused m_pSrcTarget and iarraySels. But we are also
> > assuming that DispatchEvent does nothing if it does not know the event it
> > receives, right? Just making sure this is right :)
> 
> 
> All the ones I've seen check the EventType before doing any processing.

I think there is only one implementation of DispatchEvent.

[dsinclair, 2016-11-17 19:06:25]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:06:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 19:11:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:11:02]

Try jobs failed on following builders:
  linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_asan_...)

[dsinclair, 2016-11-17 19:12:44]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-17 19:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2509283003/#ps60001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-11-17 19:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 19:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:26:02]

Try jobs failed on following builders:
  linux_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_rel/b...)

[dsinclair, 2016-11-17 19:39:59]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-17 19:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2509283003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-17 19:40:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 19:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:44:35]

Try jobs failed on following builders:
  linux on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux/builds/2836)

[dsinclair, 2016-11-17 20:27:31]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-17 20:27:32]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2509283003/#ps100001
(title: "Rebase ...")

[commit-bot: I haz the power, 2016-11-17 20:27:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:31:50]

Try jobs failed on following builders:
  linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_asan_...)

[dsinclair, 2016-11-17 20:45:52]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:46:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:50:15]

Try jobs failed on following builders:
  linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_asan_...)

[dsinclair, 2016-11-17 20:57:55]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:07:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:07:11]

Try jobs failed on following builders:
  linux_xfa_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa_asan_...)

[dsinclair, 2016-11-17 21:08:55]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:09:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-17 21:10:08]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-11-17 21:10:08]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:10:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:15:18]

Description was changed from

==========
Unify the three CFWL_EventType::SelectChange classes.

This CL removes the ListBox SelectChange class as it is never processed. The
other two have been unified into a single classs.
==========

to

==========
Unify the three CFWL_EventType::SelectChange classes.

This CL removes the ListBox SelectChange class as it is never processed. The
other two have been unified into a single classs.

Committed:
https://pdfium.googlesource.com/pdfium/+/3855f7ff0d4c5c8653fc17219bf65c4a0a95...
==========

[commit-bot: I haz the power, 2016-11-17 21:15:20]

Committed patchset #6 (id:100001) as
https://pdfium.googlesource.com/pdfium/+/3855f7ff0d4c5c8653fc17219bf65c4a0a95...