Unify the three CFWL_EventType::SelectChange classes.

xfa/fwl/core/ifwl_listbox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_listbox.h"
 
 #include "third_party/base/ptr_util.h"
 #include "xfa/fde/tto/fde_textout.h"
@@ skipping 825 matching lines @@
 bool IFWL_ListBox::IsShowScrollBar(bool bVert) {
   IFWL_ScrollBar* pScrollbar =
       bVert ? m_pVertScrollBar.get() : m_pHorzScrollBar.get();
   if (!pScrollbar || (pScrollbar->GetStates() & FWL_WGTSTATE_Invisible))
     return false;
   return !(m_pProperties->m_dwStyleExes &
            FWL_STYLEEXT_LTB_ShowScrollBarFocus) ||
          (m_pProperties->m_dwStates & FWL_WGTSTATE_Focused);
 }
 
-void IFWL_ListBox::ProcessSelChanged() {
-  CFWL_EvtLtbSelChanged selEvent;
-  selEvent.m_pSrcTarget = this;
-  CFX_Int32Array arrSels;
-  int32_t iCount = CountSelItems();
-  for (int32_t i = 0; i < iCount; i++) {
-    CFWL_ListItem* item = GetSelItem(i);
-    if (!item)
-      continue;
-    selEvent.iarraySels.Add(i);
-  }
-  DispatchEvent(&selEvent);

[npm, 2016/11/17 18:39:07]

I agree with deletion of unused m_pSrcTarget and iarraySels. But we are also
assuming that DispatchEvent does nothing if it does not know the event it
receives, right? Just making sure this is right :)

[dsinclair, 2016/11/17 18:39:54]

All the ones I've seen check the EventType before doing any processing.

[npm, 2016/11/17 18:45:07]

I think there is only one implementation of DispatchEvent.

-}
-
 void IFWL_ListBox::OnProcessMessage(CFWL_Message* pMessage) {
   if (!pMessage)
     return;
   if (!IsEnabled())
     return;
 
   CFWL_MessageType dwMsgCode = pMessage->GetClassID();
   switch (dwMsgCode) {
     case CFWL_MessageType::SetFocus:
       OnFocusChanged(pMessage, true);
@@ skipping 97 matching lines @@
     GetItemCheckRect(hSelectedItem, rtCheck);
     bool bChecked = GetItemChecked(pItem);
     if (rtCheck.Contains(pMsg->m_fx, pMsg->m_fy)) {
       SetItemChecked(pItem, !bChecked);
       Update();
     }
   }
   SetFocusItem(pItem);
   ScrollToVisible(pItem);
   SetGrab(true);
-  ProcessSelChanged();
   Repaint(&m_rtClient);
 }
 
 void IFWL_ListBox::OnLButtonUp(CFWL_MsgMouse* pMsg) {
   if (!m_bLButtonDown)
     return;
 
   m_bLButtonDown = false;
   SetGrab(false);
-  DispatchSelChangedEv();
 }
 
 void IFWL_ListBox::OnMouseWheel(CFWL_MsgMouseWheel* pMsg) {
   if (IsShowScrollBar(true))
     m_pVertScrollBar->GetDelegate()->OnProcessMessage(pMsg);
 }
 
 void IFWL_ListBox::OnKeyDown(CFWL_MsgKey* pMsg) {
   uint32_t dwKeyCode = pMsg->m_dwKeyCode;
   switch (dwKeyCode) {
     case FWL_VKEY_Tab:
     case FWL_VKEY_Up:
     case FWL_VKEY_Down:
     case FWL_VKEY_Home:
     case FWL_VKEY_End: {
       CFWL_ListItem* pItem = GetFocusedItem();
       pItem = GetItem(pItem, dwKeyCode);
       bool bShift = !!(pMsg->m_dwFlags & FWL_KEYFLAG_Shift);
       bool bCtrl = !!(pMsg->m_dwFlags & FWL_KEYFLAG_Ctrl);
       OnVK(pItem, bShift, bCtrl);
-      DispatchSelChangedEv();
-      ProcessSelChanged();
       break;
     }
     default:
       break;
   }
 }
 
 void IFWL_ListBox::OnVK(CFWL_ListItem* pItem, bool bShift, bool bCtrl) {
   if (!pItem)
     return;
@@ skipping 70 matching lines @@
     case FWL_SCBCODE::EndScroll:
       return false;
   }
   if (iCurPos != fPos) {
     pScrollBar->SetPos(fPos);
     pScrollBar->SetTrackPos(fPos);
     Repaint(&m_rtClient);
   }
   return true;
 }
-
-void IFWL_ListBox::DispatchSelChangedEv() {
-  CFWL_EvtLtbSelChanged ev;
-  ev.m_pSrcTarget = this;
-  DispatchEvent(&ev);
-}