Unify the three CFWL_EventType::SelectChange classes.

xfa/fwl/core/ifwl_listbox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_listbox.h"
 
 #include "third_party/base/ptr_util.h"
 #include "xfa/fde/tto/fde_textout.h"
@@ skipping 825 matching lines @@
 bool IFWL_ListBox::IsShowScrollBar(bool bVert) {
   IFWL_ScrollBar* pScrollbar =
       bVert ? m_pVertScrollBar.get() : m_pHorzScrollBar.get();
   if (!pScrollbar || (pScrollbar->GetStates() & FWL_WGTSTATE_Invisible))
     return false;
   return !(m_pProperties->m_dwStyleExes &
            FWL_STYLEEXT_LTB_ShowScrollBarFocus) ||
          (m_pProperties->m_dwStates & FWL_WGTSTATE_Focused);
 }
 
-void IFWL_ListBox::ProcessSelChanged() {

[npm, 2016/11/17 18:07:02]

Can we delete this method altogether?

[dsinclair, 2016/11/17 18:13:19]

Done.

-  CFWL_EvtLtbSelChanged selEvent;
-  selEvent.m_pSrcTarget = this;
-  CFX_Int32Array arrSels;
-  int32_t iCount = CountSelItems();
-  for (int32_t i = 0; i < iCount; i++) {
-    CFWL_ListItem* item = GetSelItem(i);
-    if (!item)
-      continue;
-    selEvent.iarraySels.Add(i);
-  }
-  DispatchEvent(&selEvent);
-}
+void IFWL_ListBox::ProcessSelChanged() {}
 
 void IFWL_ListBox::OnProcessMessage(CFWL_Message* pMessage) {
   if (!pMessage)
     return;
   if (!IsEnabled())
     return;
 
   CFWL_MessageType dwMsgCode = pMessage->GetClassID();
   switch (dwMsgCode) {
     case CFWL_MessageType::SetFocus:
@@ skipping 222 matching lines @@
       return false;
   }
   if (iCurPos != fPos) {
     pScrollBar->SetPos(fPos);
     pScrollBar->SetTrackPos(fPos);
     Repaint(&m_rtClient);
   }
   return true;
 }
 
-void IFWL_ListBox::DispatchSelChangedEv() {

[npm, 2016/11/17 18:07:02]

Ditto

[dsinclair, 2016/11/17 18:13:19]

Done.

-  CFWL_EvtLtbSelChanged ev;
-  ev.m_pSrcTarget = this;
-  DispatchEvent(&ev);
-}
+void IFWL_ListBox::DispatchSelChangedEv() {}