Unify the three CFWL_EventType::SelectChange classes.

xfa/fwl/core/ifwl_combobox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_combobox.h"
 
 #include "third_party/base/ptr_util.h"
 #include "xfa/fde/cfde_txtedtengine.h"
 #include "xfa/fde/tto/fde_textout.h"
 #include "xfa/fwl/core/cfwl_evteditchanged.h"
 #include "xfa/fwl/core/cfwl_evtpostdropdown.h"
 #include "xfa/fwl/core/cfwl_evtpredropdown.h"
+#include "xfa/fwl/core/cfwl_evtselectchanged.h"
 #include "xfa/fwl/core/cfwl_evttextchanged.h"
 #include "xfa/fwl/core/cfwl_msgkey.h"
 #include "xfa/fwl/core/cfwl_msgkillfocus.h"
 #include "xfa/fwl/core/cfwl_msgmouse.h"
 #include "xfa/fwl/core/cfwl_msgsetfocus.h"
 #include "xfa/fwl/core/cfwl_themebackground.h"
 #include "xfa/fwl/core/cfwl_themepart.h"
 #include "xfa/fwl/core/cfwl_themetext.h"
 #include "xfa/fwl/core/cfwl_widgetmgr.h"
 #include "xfa/fwl/core/fwl_noteimp.h"
@@ skipping 530 matching lines @@
     return;
 
   CFX_WideString wsText;
   pData->GetItemText(this, hItem, wsText);
   if (m_pEdit) {
     m_pEdit->SetText(wsText);
     m_pEdit->Update();
     m_pEdit->SetSelected();
   }
 
-  CFWL_EvtCmbSelChanged ev;
+  CFWL_EvtSelectChanged ev;
   ev.bLButtonUp = bLButtonUp;
   ev.m_pSrcTarget = this;
-  ev.iArraySels.Add(m_iCurSel);

[npm, 2016/11/17 18:07:02]

Is iArraySels never used, or why is this deleted?

[dsinclair, 2016/11/17 18:13:19]

Removed from class, compiler is happy.

   DispatchEvent(&ev);
 }
 
 void IFWL_ComboBox::InitProxyForm() {
   if (m_pComboBoxProxy)
     return;
   if (!m_pListBox)
     return;
 
   auto prop = pdfium::MakeUnique<CFWL_WidgetProperties>();
@@ skipping 548 matching lines @@
       else
         iCurSel++;
     }
     m_iCurSel = iCurSel;
     SyncEditText(m_iCurSel);
     return;
   }
   if (m_pEdit)
     m_pEdit->GetDelegate()->OnProcessMessage(pMsg);
 }