Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2506883002: Revert of Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)

Created:
4 years, 1 month ago by suzyh_UTC10 (ex-contributor)
Modified:
4 years, 1 month ago
CC:
anandc+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, miu+watch_chromium.org, nasko+codewatch_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, piman+watch_chromium.org, rjkroege, scf+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove SurfaceFactory::Create and SurfaceFactory::Destroy (patchset #40 id:880001 of https://codereview.chromium.org/2485473003/ ) Reason for revert: Seems to have broken windows compile: https://build.chromium.org/p/chromium/builders/Win/builds/49156 Original issue's description: > Remove SurfaceFactory::Create and SurfaceFactory::Destroy > > It is no longer possible to explicitly construct and destroy surfaces. A > SurfaceFactory instance now handles only one surface at a time. Once the > local frame id passed to SubmitCompositorFrame changes, the factory gets > rid of the old surface and creates a new one. > > BUG=658607 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/b902fd366ba91757dbee99d5f821f00d2de1d181 > Cr-Commit-Position: refs/heads/master@{#432312} TBR=reveman@chromium.org,boliu@chromium.org,danakj@chromium.org,dtrainor@chromium.org,fsamuel@chromium.org,jbauman@chromium.org,piman@chromium.org,sky@chromium.org,samans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=658607 Committed: https://crrev.com/5cdae2b53317c08448d0e765a0443934deb788c3 Cr-Commit-Position: refs/heads/master@{#432370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -453 lines) Patch
M android_webview/browser/hardware_renderer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/browser/surfaces_instance.cc View 2 chunks +3 lines, -1 line 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 2 chunks +6 lines, -1 line 0 comments Download
M cc/surfaces/display_unittest.cc View 5 chunks +7 lines, -1 line 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 6 chunks +21 lines, -22 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 51 chunks +152 lines, -173 lines 0 comments Download
M cc/surfaces/surface_factory.h View 4 chunks +31 lines, -27 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 2 chunks +58 lines, -47 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 15 chunks +44 lines, -36 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 15 chunks +18 lines, -9 lines 0 comments Download
M cc/surfaces/surface_manager_ref_unittest.cc View 6 chunks +4 lines, -15 lines 0 comments Download
M cc/surfaces/surface_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 10 chunks +23 lines, -27 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M components/exo/surface.cc View 2 chunks +10 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 2 chunks +12 lines, -14 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 5 chunks +17 lines, -15 lines 0 comments Download
M content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 7 chunks +24 lines, -31 lines 0 comments Download
M services/ui/ws/gpu_compositor_frame_sink.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ui/android/delegated_frame_host_android.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
suzyh_UTC10 (ex-contributor)
Created Revert of Remove SurfaceFactory::Create and SurfaceFactory::Destroy
4 years, 1 month ago (2016-11-16 03:06:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2506883002/1
4 years, 1 month ago (2016-11-16 03:06:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 03:07:58 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 03:10:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cdae2b53317c08448d0e765a0443934deb788c3
Cr-Commit-Position: refs/heads/master@{#432370}

Powered by Google App Engine
This is Rietveld 408576698