Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Side by Side Diff: services/ui/ws/gpu_compositor_frame_sink.cc

Issue 2506883002: Revert of Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/ws/gpu_compositor_frame_sink.h" 5 #include "services/ui/ws/gpu_compositor_frame_sink.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/single_thread_task_runner.h" 9 #include "base/single_thread_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 this); 45 this);
46 46
47 if (widget != gfx::kNullAcceleratedWidget) 47 if (widget != gfx::kNullAcceleratedWidget)
48 InitDisplay(widget, gpu_memory_buffer_manager, std::move(context_provider)); 48 InitDisplay(widget, gpu_memory_buffer_manager, std::move(context_provider));
49 } 49 }
50 50
51 GpuCompositorFrameSink::~GpuCompositorFrameSink() { 51 GpuCompositorFrameSink::~GpuCompositorFrameSink() {
52 // SurfaceFactory's destructor will attempt to return resources which will 52 // SurfaceFactory's destructor will attempt to return resources which will
53 // call back into here and access |client_| so we should destroy 53 // call back into here and access |client_| so we should destroy
54 // |surface_factory_|'s resources early on. 54 // |surface_factory_|'s resources early on.
55 surface_factory_.EvictSurface(); 55 surface_factory_.DestroyAll();
56 display_compositor_->manager()->UnregisterSurfaceFactoryClient( 56 display_compositor_->manager()->UnregisterSurfaceFactoryClient(
57 frame_sink_id_); 57 frame_sink_id_);
58 display_compositor_->manager()->InvalidateFrameSinkId(frame_sink_id_); 58 display_compositor_->manager()->InvalidateFrameSinkId(frame_sink_id_);
59 } 59 }
60 60
61 void GpuCompositorFrameSink::SetNeedsBeginFrame(bool needs_begin_frame) { 61 void GpuCompositorFrameSink::SetNeedsBeginFrame(bool needs_begin_frame) {
62 needs_begin_frame_ = needs_begin_frame; 62 needs_begin_frame_ = needs_begin_frame;
63 UpdateNeedsBeginFramesInternal(); 63 UpdateNeedsBeginFramesInternal();
64 } 64 }
65 65
66 void GpuCompositorFrameSink::SubmitCompositorFrame(cc::CompositorFrame frame) { 66 void GpuCompositorFrameSink::SubmitCompositorFrame(cc::CompositorFrame frame) {
67 gfx::Size frame_size = frame.render_pass_list[0]->output_rect.size(); 67 gfx::Size frame_size = frame.render_pass_list[0]->output_rect.size();
68 // If the size of the CompostiorFrame has changed then destroy the existing 68 // If the size of the CompostiorFrame has changed then destroy the existing
69 // Surface and create a new one of the appropriate size. 69 // Surface and create a new one of the appropriate size.
70 if (!local_frame_id_.is_valid() || frame_size != last_submitted_frame_size_) { 70 if (!local_frame_id_.is_valid() || frame_size != last_submitted_frame_size_) {
71 if (local_frame_id_.is_valid())
72 surface_factory_.Destroy(local_frame_id_);
71 local_frame_id_ = surface_id_allocator_.GenerateId(); 73 local_frame_id_ = surface_id_allocator_.GenerateId();
74 surface_factory_.Create(local_frame_id_);
72 if (display_) 75 if (display_)
73 display_->Resize(frame_size); 76 display_->Resize(frame_size);
74 } 77 }
75 ++ack_pending_count_; 78 ++ack_pending_count_;
76 surface_factory_.SubmitCompositorFrame( 79 surface_factory_.SubmitCompositorFrame(
77 local_frame_id_, std::move(frame), 80 local_frame_id_, std::move(frame),
78 base::Bind(&GpuCompositorFrameSink::DidReceiveCompositorFrameAck, 81 base::Bind(&GpuCompositorFrameSink::DidReceiveCompositorFrameAck,
79 base::Unretained(this))); 82 base::Unretained(this)));
80 if (display_) { 83 if (display_) {
81 display_->SetLocalFrameId(local_frame_id_, 84 display_->SetLocalFrameId(local_frame_id_,
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 212
210 added_frame_observer_ = needs_begin_frame_; 213 added_frame_observer_ = needs_begin_frame_;
211 if (needs_begin_frame_) 214 if (needs_begin_frame_)
212 begin_frame_source_->AddObserver(this); 215 begin_frame_source_->AddObserver(this);
213 else 216 else
214 begin_frame_source_->RemoveObserver(this); 217 begin_frame_source_->RemoveObserver(this);
215 } 218 }
216 219
217 } // namespace ws 220 } // namespace ws
218 } // namespace ui 221 } // namespace ui
OLDNEW
« no previous file with comments | « content/renderer/android/synchronous_compositor_frame_sink.cc ('k') | ui/android/delegated_frame_host_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698