Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Side by Side Diff: content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

Issue 2506883002: Revert of Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h " 5 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h "
6 6
7 #include "cc/surfaces/surface.h" 7 #include "cc/surfaces/surface.h"
8 #include "cc/surfaces/surface_manager.h" 8 #include "cc/surfaces/surface_manager.h"
9 #include "content/browser/compositor/surface_utils.h" 9 #include "content/browser/compositor/surface_utils.h"
10 #include "mojo/public/cpp/bindings/strong_binding.h" 10 #include "mojo/public/cpp/bindings/strong_binding.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink( 14 OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink(
15 const cc::SurfaceId& surface_id, 15 const cc::SurfaceId& surface_id,
16 cc::mojom::MojoCompositorFrameSinkClientPtr client) 16 cc::mojom::MojoCompositorFrameSinkClientPtr client)
17 : surface_id_(surface_id), client_(std::move(client)) { 17 : surface_id_(surface_id), client_(std::move(client)) {
18 cc::SurfaceManager* manager = GetSurfaceManager(); 18 cc::SurfaceManager* manager = GetSurfaceManager();
19 surface_factory_ = base::MakeUnique<cc::SurfaceFactory>( 19 surface_factory_ = base::MakeUnique<cc::SurfaceFactory>(
20 surface_id_.frame_sink_id(), manager, this); 20 surface_id_.frame_sink_id(), manager, this);
21 manager->RegisterFrameSinkId(surface_id_.frame_sink_id()); 21 manager->RegisterFrameSinkId(surface_id_.frame_sink_id());
22 surface_factory_->Create(surface_id_.local_frame_id());
22 } 23 }
23 24
24 OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() { 25 OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {
25 cc::SurfaceManager* manager = GetSurfaceManager(); 26 cc::SurfaceManager* manager = GetSurfaceManager();
26 if (!manager) { 27 if (!manager) {
27 // Inform SurfaceFactory that SurfaceManager's no longer alive to 28 // Inform SurfaceFactory that SurfaceManager's no longer alive to
28 // avoid its destruction error. 29 // avoid its destruction error.
29 surface_factory_->DidDestroySurfaceManager(); 30 surface_factory_->DidDestroySurfaceManager();
30 } else { 31 } else {
31 manager->InvalidateFrameSinkId(surface_id_.frame_sink_id()); 32 manager->InvalidateFrameSinkId(surface_id_.frame_sink_id());
32 } 33 }
33 surface_factory_->EvictSurface(); 34 surface_factory_->Destroy(surface_id_.local_frame_id());
34 } 35 }
35 36
36 // static 37 // static
37 void OffscreenCanvasCompositorFrameSink::Create( 38 void OffscreenCanvasCompositorFrameSink::Create(
38 const cc::SurfaceId& surface_id, 39 const cc::SurfaceId& surface_id,
39 cc::mojom::MojoCompositorFrameSinkClientPtr client, 40 cc::mojom::MojoCompositorFrameSinkClientPtr client,
40 cc::mojom::MojoCompositorFrameSinkRequest request) { 41 cc::mojom::MojoCompositorFrameSinkRequest request) {
41 mojo::MakeStrongBinding(base::MakeUnique<OffscreenCanvasCompositorFrameSink>( 42 mojo::MakeStrongBinding(base::MakeUnique<OffscreenCanvasCompositorFrameSink>(
42 surface_id, std::move(client)), 43 surface_id, std::move(client)),
43 std::move(request)); 44 std::move(request));
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 client_->DidReceiveCompositorFrameAck(); 86 client_->DidReceiveCompositorFrameAck();
86 DCHECK_GT(ack_pending_count_, 0); 87 DCHECK_GT(ack_pending_count_, 0);
87 if (!surface_returned_resources_.empty()) { 88 if (!surface_returned_resources_.empty()) {
88 client_->ReclaimResources(surface_returned_resources_); 89 client_->ReclaimResources(surface_returned_resources_);
89 surface_returned_resources_.clear(); 90 surface_returned_resources_.clear();
90 } 91 }
91 ack_pending_count_--; 92 ack_pending_count_--;
92 } 93 }
93 94
94 } // namespace content 95 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | content/renderer/android/synchronous_compositor_frame_sink.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698