Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2503283002: cc: Cleanup class/struct forward declarations (Closed)

Created:
4 years, 1 month ago by jbriance
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, scheduler-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Cleanup class/struct forward declarations Remove useless class and struct forward declarations, and add missing ones in cc header files. BUG=662195 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/58f287687a11f1b9f35371aa708e8b93269b3974 Cr-Commit-Position: refs/heads/master@{#432964}

Patch Set 1 #

Patch Set 2 : Add missing fwd class decl in blimp_embedder_compositor.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -237 lines) Patch
M blimp/client/support/compositor/blimp_embedder_compositor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/animation/animation_curve.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/element_animations.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/animation/scroll_offset_animations_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/blimp/layer_tree_host_remote.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/blimp/remote_compositor_bridge_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/blink/web_content_layer_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/blink/web_display_item_list_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M cc/debug/invalidation_benchmark.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/browser_controls_offset_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/input/browser_controls_offset_manager_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/input/input_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/input/scrollbar_animation_controller_linear_fade.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/input/scrollbar_animation_controller_thinning.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/cc_param_traits.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/heads_up_display_layer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer.h View 2 chunks +0 lines, -10 lines 0 comments Download
M cc/layers/layer_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/layers/layer_list_iterator.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/nine_patch_layer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/layers/scrollbar_layer_interface.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/layers/texture_layer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/compositor_frame_sink.h View 2 chunks +0 lines, -12 lines 0 comments Download
M cc/output/context_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/dynamic_geometry_binding.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/filter_operation.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/filter_operations.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/geometry_binding.h View 2 chunks +0 lines, -10 lines 0 comments Download
M cc/output/gl_renderer.h View 3 chunks +0 lines, -4 lines 0 comments Download
M cc/output/output_surface.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/output/output_surface_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/output/software_output_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/playback/display_item_list.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/playback/recording_source.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/quads/render_pass.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/quads/shared_quad_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/raster/one_copy_raster_buffer_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/raster/raster_buffer_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/raster/staging_buffer_pool.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/resources/ui_resource_bitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/display.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/surfaces/display_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/display_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/surfaces/surface_factory_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/surfaces/surface_hittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/fake_compositor_frame_sink_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/test/fake_output_surface_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/fake_scoped_ui_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/layer_tree_host_remote_for_testing.h View 1 chunk +1 line, -5 lines 0 comments Download
M cc/test/layer_tree_pixel_test.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +0 lines, -8 lines 0 comments Download
M cc/test/surface_aggregator_test_helpers.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/surface_hittest_test_helpers.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/test_hooks.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/tiles/tile.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/damage_tracker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/draw_property_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/proxy_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/trees/proxy_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/task_runner_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/tree_synchronizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
jbriance
4 years, 1 month ago (2016-11-16 08:12:32 UTC) #3
ccameron
lgtm
4 years, 1 month ago (2016-11-16 21:41:54 UTC) #4
danakj
LGTM
4 years, 1 month ago (2016-11-16 21:44:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503283002/1
4 years, 1 month ago (2016-11-16 21:49:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316395) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-16 22:23:17 UTC) #9
jbriance
+ nyquist for blimp/client/support/compositor/blimp_embedder_compositor.h + dcheng for cc/ipc/cc_param_traits.h
4 years, 1 month ago (2016-11-16 22:40:10 UTC) #11
dcheng
ipc rs lgtm
4 years, 1 month ago (2016-11-16 22:40:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503283002/20001
4 years, 1 month ago (2016-11-17 08:00:43 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/306737)
4 years, 1 month ago (2016-11-17 08:09:54 UTC) #21
jbriance
+ dtrainor, kmarshall and wez to be able to submit: ** Presubmit ERRORS ** Missing ...
4 years, 1 month ago (2016-11-17 08:17:31 UTC) #23
Wez
blimp/ LGTM
4 years, 1 month ago (2016-11-17 19:00:37 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503283002/20001
4 years, 1 month ago (2016-11-17 20:53:31 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:38:21 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58f287687a11f1b9f35371aa708e8b93269b3974
Cr-Commit-Position: refs/heads/master@{#432964}

Powered by Google App Engine
This is Rietveld 408576698