Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2503203002: Revert "Getting rid of DelegatedFrameData" (Closed)

Created:
4 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
4 years, 1 month ago
CC:
ajuma+watch_chromium.org, anandc+watch-blimp_chromium.org, android-webview-reviews_chromium.org, bgoldman+watch-blimp_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, dtrainor+watch-blimp_chromium.org, f(malita), fuzzing_chromium.org, gcasto+watch-blimp_chromium.org, jam, jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, mac-reviews_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, nyquist+watch-blimp_chromium.org, pdr+graphicswatchlist_chromium.org, perumaal+watch-blimp_chromium.org, piman+watch_chromium.org, rjkroege, rwlbuis, scf+watch-blimp_chromium.org, Stephen Chennney, shaktisahu+watch-blimp_chromium.org, shuchen+watch_chromium.org, sriramsr+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, James Su, xjz+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Getting rid of DelegatedFrameData" This reverts commit 4ba3a0e9d06bf66b3d900fec44bcf8ee4a2964a2, which caused a browser-animation framerate regression on Android. NOTRY=true TBR=boliu@chromium.org,danakj@chromium.org,fsamuel@chromium.org,dtrainor@chromium.org,piman@chromium.org,reveman@chromium.org,sky@chromium.org,tsepez@chromium.org BUG=663516, 653741 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/eb9ecefc55d1e3cf8498d0865568097fb9bbf285 Cr-Commit-Position: refs/heads/master@{#432390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1117 lines, -374 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M android_webview/browser/surfaces_instance.cc View 2 chunks +6 lines, -1 line 0 comments Download
M android_webview/browser/test/rendering_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/ipc/cc_param_traits.h View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/ipc/cc_param_traits.cc View 4 chunks +60 lines, -13 lines 0 comments Download
M cc/ipc/cc_param_traits_unittest.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M cc/ipc/cc_serialization_perftest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/ipc/compositor_frame_struct_traits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/ipc/compositor_frame_struct_traits.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 2 chunks +11 lines, -6 lines 0 comments Download
M cc/output/compositor_frame.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/output/compositor_frame.cc View 1 chunk +1 line, -0 lines 0 comments Download
A cc/output/delegated_frame_data.h View 1 chunk +29 lines, -0 lines 0 comments Download
A cc/output/delegated_frame_data.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M cc/surfaces/direct_compositor_frame_sink.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/direct_compositor_frame_sink_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/surfaces/display.cc View 6 chunks +15 lines, -11 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 4 chunks +11 lines, -3 lines 0 comments Download
M cc/surfaces/surface.h View 3 chunks +4 lines, -6 lines 0 comments Download
M cc/surfaces/surface.cc View 8 chunks +33 lines, -26 lines 0 comments Download
M cc/surfaces/surface_aggregator.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.cc View 14 chunks +34 lines, -30 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 5 chunks +10 lines, -5 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 51 chunks +334 lines, -136 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 11 chunks +30 lines, -10 lines 0 comments Download
M cc/surfaces/surface_hittest.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 9 chunks +35 lines, -9 lines 0 comments Download
M cc/test/fake_compositor_frame_sink.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M cc/test/surface_aggregator_test_helpers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/surface_hittest_test_helpers.cc View 2 chunks +18 lines, -4 lines 0 comments Download
M cc/test/test_compositor_frame_sink.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M components/exo/surface.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/exo/surface_unittest.cc View 4 chunks +12 lines, -10 lines 0 comments Download
M content/browser/bad_message.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 2 chunks +10 lines, -3 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M services/ui/demo/bitmap_uploader.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A services/ui/surfaces/display_compositor_frame_sink.cc View 1 chunk +135 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M services/ui/ws/gpu_compositor_frame_sink.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/platform_display.cc View 1 chunk +1 line, -0 lines 0 comments Download
A services/ui/ws/server_window_compositor_frame_sink.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M ui/android/delegated_frame_host_android.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503203002/1
4 years, 1 month ago (2016-11-16 04:02:44 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-16 06:27:30 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 06:29:51 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eb9ecefc55d1e3cf8498d0865568097fb9bbf285
Cr-Commit-Position: refs/heads/master@{#432390}

Powered by Google App Engine
This is Rietveld 408576698