Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: content/browser/renderer_host/delegated_frame_host.cc

Issue 2503203002: Revert "Getting rid of DelegatedFrameData" (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/delegated_frame_host.cc
diff --git a/content/browser/renderer_host/delegated_frame_host.cc b/content/browser/renderer_host/delegated_frame_host.cc
index 9505792fd0c14a225865dafd7ca08cd099daf730..ca5ee37118ed0f28f9ba22f6edce3c0607cdbe48 100644
--- a/content/browser/renderer_host/delegated_frame_host.cc
+++ b/content/browser/renderer_host/delegated_frame_host.cc
@@ -406,14 +406,16 @@ void DelegatedFrameHost::AttemptFrameSubscriberCapture(
void DelegatedFrameHost::SwapDelegatedFrame(uint32_t compositor_frame_sink_id,
cc::CompositorFrame frame) {
+ DCHECK(frame.delegated_frame_data.get());
#if defined(OS_CHROMEOS)
DCHECK(!resize_lock_ || !client_->IsAutoResizeEnabled());
#endif
+ cc::DelegatedFrameData* frame_data = frame.delegated_frame_data.get();
float frame_device_scale_factor = frame.metadata.device_scale_factor;
- DCHECK(!frame.render_pass_list.empty());
+ DCHECK(!frame_data->render_pass_list.empty());
- cc::RenderPass* root_pass = frame.render_pass_list.back().get();
+ cc::RenderPass* root_pass = frame_data->render_pass_list.back().get();
gfx::Size frame_size = root_pass->output_rect.size();
gfx::Size frame_size_in_dip =
@@ -426,7 +428,8 @@ void DelegatedFrameHost::SwapDelegatedFrame(uint32_t compositor_frame_sink_id,
if (ShouldSkipFrame(frame_size_in_dip)) {
cc::ReturnedResourceArray resources;
- cc::TransferableResource::ReturnResources(frame.resource_list, &resources);
+ cc::TransferableResource::ReturnResources(frame_data->resource_list,
+ &resources);
skipped_latency_info_list_.insert(skipped_latency_info_list_.end(),
frame.metadata.latency_info.begin(),
@@ -444,7 +447,7 @@ void DelegatedFrameHost::SwapDelegatedFrame(uint32_t compositor_frame_sink_id,
damage_rect_in_dip = gfx::Rect(frame_size_in_dip);
// Give the same damage rect to the compositor.
- cc::RenderPass* root_pass = frame.render_pass_list.back().get();
+ cc::RenderPass* root_pass = frame_data->render_pass_list.back().get();
root_pass->damage_rect = damage_rect;
}
@@ -471,7 +474,7 @@ void DelegatedFrameHost::SwapDelegatedFrame(uint32_t compositor_frame_sink_id,
background_color_ = frame.metadata.root_background_color;
if (frame_size.IsEmpty()) {
- DCHECK(frame.resource_list.empty());
+ DCHECK(frame_data->resource_list.empty());
EvictDelegatedFrame();
} else {
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
« no previous file with comments | « content/browser/renderer_host/browser_compositor_view_mac.mm ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698