Cleanup remaining IFWL files for visiblity and usage.

Cleanup remaining IFWL files for visiblity and usage.

This CL cleans up the remaining ifwl_* files to fixup visibility, remove
unused methods and remove unused FWL_Error return codes.

Committed: https://pdfium.googlesource.com/pdfium/+/c64b76c97c7f469ebd4126f314badceeb8a78b8b

[dsinclair, 2016-11-14 14:47:56]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 14:48:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-14 14:48:06]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-14 14:48:07]

PTAL.

[commit-bot: I haz the power, 2016-11-14 15:07:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 15:07:37]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-14 15:19:30]

lgtm

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_caret.cpp
File xfa/fwl/core/ifwl_caret.cpp (right):

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_caret.cpp...
xfa/fwl/core/ifwl_caret.cpp:18: const int kFrequency = 400;
nit: uint32_t

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox.cpp
File xfa/fwl/core/ifwl_checkbox.cpp (right):

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox....
xfa/fwl/core/ifwl_checkbox.cpp:149: case 0: {
nit: I think we don't use braces in switch cases?

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox....
xfa/fwl/core/ifwl_checkbox.cpp:151: }
nit: remove case 0

[dsinclair, 2016-11-14 16:40:37]

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_caret.cpp
File xfa/fwl/core/ifwl_caret.cpp (right):

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_caret.cpp...
xfa/fwl/core/ifwl_caret.cpp:18: const int kFrequency = 400;
On 2016/11/14 15:19:30, npm wrote:
> nit: uint32_t

Done.

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox.cpp
File xfa/fwl/core/ifwl_checkbox.cpp (right):

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox....
xfa/fwl/core/ifwl_checkbox.cpp:149: case 0: {
On 2016/11/14 15:19:30, npm wrote:
> nit: I think we don't use braces in switch cases?

Done.

https://codereview.chromium.org/2502653002/diff/1/xfa/fwl/core/ifwl_checkbox....
xfa/fwl/core/ifwl_checkbox.cpp:151: }
On 2016/11/14 15:19:30, npm wrote:
> nit: remove case 0

Done.

[dsinclair, 2016-11-14 16:40:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-14 16:40:43]

The patchset sent to the CQ was uploaded after l-g-t-m from npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2502653002/#ps20001
(title: "Review cleanup")

[commit-bot: I haz the power, 2016-11-14 16:40:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 17:01:40]

Description was changed from

==========
Cleanup remaining IFWL files for visiblity and usage.

This CL cleans up the remaining ifwl_* files to fixup visibility, remove
unused methods and remove unused FWL_Error return codes.
==========

to

==========
Cleanup remaining IFWL files for visiblity and usage.

This CL cleans up the remaining ifwl_* files to fixup visibility, remove
unused methods and remove unused FWL_Error return codes.

Committed:
https://pdfium.googlesource.com/pdfium/+/c64b76c97c7f469ebd4126f314badceeb8a7...
==========

[commit-bot: I haz the power, 2016-11-14 17:01:41]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c64b76c97c7f469ebd4126f314badceeb8a7...