Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1726)

Unified Diff: fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp

Issue 2502653002: Cleanup remaining IFWL files for visiblity and usage. (Closed)
Patch Set: Review cleanup Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h ('k') | xfa/fwl/core/cfwl_barcode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp
diff --git a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp
index f5e36d4a6723754b2fd16759e978f142890d6b4b..5a9ae95be7593d1efd31d287abbe5622ad3cd507 100644
--- a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp
+++ b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp
@@ -13,12 +13,12 @@
std::vector<CFWL_TimerInfo*>* CXFA_FWLAdapterTimerMgr::s_TimerArray = nullptr;
-FWL_Error CXFA_FWLAdapterTimerMgr::Start(IFWL_Timer* pTimer,
- uint32_t dwElapse,
- bool bImmediately,
- IFWL_TimerInfo** pTimerInfo) {
+void CXFA_FWLAdapterTimerMgr::Start(IFWL_Timer* pTimer,
+ uint32_t dwElapse,
+ bool bImmediately,
+ IFWL_TimerInfo** pTimerInfo) {
if (!m_pFormFillEnv)
- return FWL_Error::Indefinite;
+ return;
int32_t id_event = m_pFormFillEnv->SetTimer(dwElapse, TimerProc);
if (!s_TimerArray)
@@ -26,12 +26,11 @@ FWL_Error CXFA_FWLAdapterTimerMgr::Start(IFWL_Timer* pTimer,
s_TimerArray->push_back(new CFWL_TimerInfo(this, id_event, pTimer));
*pTimerInfo = s_TimerArray->back();
- return FWL_Error::Succeeded;
}
-FWL_Error CXFA_FWLAdapterTimerMgr::Stop(IFWL_TimerInfo* pTimerInfo) {
+void CXFA_FWLAdapterTimerMgr::Stop(IFWL_TimerInfo* pTimerInfo) {
if (!pTimerInfo || !m_pFormFillEnv)
- return FWL_Error::Indefinite;
+ return;
CFWL_TimerInfo* pInfo = static_cast<CFWL_TimerInfo*>(pTimerInfo);
m_pFormFillEnv->KillTimer(pInfo->idEvent);
@@ -42,7 +41,6 @@ FWL_Error CXFA_FWLAdapterTimerMgr::Stop(IFWL_TimerInfo* pTimerInfo) {
delete pInfo;
}
}
- return FWL_Error::Succeeded;
}
// static
« no previous file with comments | « fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h ('k') | xfa/fwl/core/cfwl_barcode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698