Cleanup remaining IFWL files for visiblity and usage.

xfa/fwl/core/ifwl_checkbox.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fwl/core/ifwl_checkbox.h"
 
 #include <algorithm>
 
@@ skipping 125 matching lines @@
       textParam.m_matrix.Concat(*pMatrix);
     }
     textParam.m_rtPart = m_rtCaption;
     textParam.m_wsText = wsCaption;
     textParam.m_dwTTOStyles = m_dwTTOStyles;
     textParam.m_iTTOAlign = m_iTTOAlign;
     pTheme->DrawText(&textParam);
   }
 }
 
-int32_t IFWL_CheckBox::GetCheckState() {
-  if ((m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CKB_3State) &&
-      ((m_pProperties->m_dwStates & FWL_STATE_CKB_CheckMask) ==
-       FWL_STATE_CKB_Neutral)) {
-    return 2;
-  }
-  if ((m_pProperties->m_dwStates & FWL_STATE_CKB_CheckMask) ==
-      FWL_STATE_CKB_Checked) {
-    return 1;
-  }
-  return 0;
-}
-
-FWL_Error IFWL_CheckBox::SetCheckState(int32_t iCheck) {
+void IFWL_CheckBox::SetCheckState(int32_t iCheck) {
   m_pProperties->m_dwStates &= ~FWL_STATE_CKB_CheckMask;
   switch (iCheck) {
     case 0: {

[npm, 2016/11/14 15:19:30]

nit: I think we don't use braces in switch cases?

[dsinclair, 2016/11/14 16:40:37]

Done.

       break;
     }

[npm, 2016/11/14 15:19:30]

nit: remove case 0

[dsinclair, 2016/11/14 16:40:37]

Done.

     case 1: {
       m_pProperties->m_dwStates |= FWL_STATE_CKB_Checked;
       break;
     }
     case 2: {
       if (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CKB_3State) {
         m_pProperties->m_dwStates |= FWL_STATE_CKB_Neutral;
       }
       break;
     }
-    default: {}
+    default:
+      break;
   }
   Repaint(&m_rtClient);
-  return FWL_Error::Succeeded;
 }
 
 void IFWL_CheckBox::Layout() {
   int32_t width = int32_t(m_pProperties->m_rtWidget.width + 0.5f);
   int32_t height = int32_t(m_pProperties->m_rtWidget.height + 0.5f);
   m_pProperties->m_rtWidget.width = (FX_FLOAT)width;
   m_pProperties->m_rtWidget.height = (FX_FLOAT)height;
   GetClientRect(m_rtClient);
   FX_FLOAT fBoxTop = m_rtClient.top;
   FX_FLOAT fBoxLeft = m_rtClient.left;
@@ skipping 340 matching lines @@
 void IFWL_CheckBox::OnKeyDown(CFWL_MsgKey* pMsg) {
   if (pMsg->m_dwKeyCode == FWL_VKEY_Tab) {
     DispatchKeyEvent(pMsg);
     return;
   }
   if (pMsg->m_dwKeyCode == FWL_VKEY_Return ||
       pMsg->m_dwKeyCode == FWL_VKEY_Space) {
     NextStates();
   }
 }