Cleanup fwl_* classes and cfx_* classes in fwl.

Cleanup fwl_* classes and cfx_* classes in fwl.

This CL cleans up the classes in the fwl_* and cfx_* files in fwl/core.

Committed: https://pdfium.googlesource.com/pdfium/+/3439802410dc2c4aeb49397c987bf5ca0ddfad8b

[dsinclair, 2016-11-14 15:24:19]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org

[dsinclair, 2016-11-14 15:24:20]

PTAL.

[dsinclair, 2016-11-14 15:24:22]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 15:24:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 15:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 15:31:31]

Dry run: Try jobs failed on following builders:
  mac_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa/builds/...)

[npm, 2016-11-14 16:31:51]

looks good once bots compile

https://codereview.chromium.org/2503513002/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2503513002/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:183: if (nIndex < 0) {
nit: no {}

[dsinclair, 2016-11-14 16:44:07]

https://codereview.chromium.org/2503513002/diff/1/xfa/fwl/core/fwl_noteimp.cpp
File xfa/fwl/core/fwl_noteimp.cpp (right):

https://codereview.chromium.org/2503513002/diff/1/xfa/fwl/core/fwl_noteimp.cp...
xfa/fwl/core/fwl_noteimp.cpp:183: if (nIndex < 0) {
On 2016/11/14 16:31:51, npm wrote:
> nit: no {}

Done.

[Tom Sepez, 2016-11-14 17:35:22]

lgtm

https://codereview.chromium.org/2503513002/diff/40001/xfa/fwl/core/ifwl_form.cpp
File xfa/fwl/core/ifwl_form.cpp (right):

https://codereview.chromium.org/2503513002/diff/40001/xfa/fwl/core/ifwl_form....
xfa/fwl/core/ifwl_form.cpp:332: m_pNoteLoop.reset(new CFWL_NoteLoop);
nit: pdfium::MakeUnique?

[dsinclair, 2016-11-14 21:03:00]

https://codereview.chromium.org/2503513002/diff/40001/xfa/fwl/core/ifwl_form.cpp
File xfa/fwl/core/ifwl_form.cpp (right):

https://codereview.chromium.org/2503513002/diff/40001/xfa/fwl/core/ifwl_form....
xfa/fwl/core/ifwl_form.cpp:332: m_pNoteLoop.reset(new CFWL_NoteLoop);
On 2016/11/14 17:35:22, Tom Sepez wrote:
> nit: pdfium::MakeUnique?

Done.

[dsinclair, 2016-11-14 21:03:03]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-11-14 21:03:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2503513002/#ps60001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-11-14 21:03:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-11-14 22:41:53]

The CQ bit was unchecked by dsinclair@chromium.org

[dsinclair, 2016-11-14 22:41:56]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-14 22:42:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:03:51]

Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)

[dsinclair, 2016-11-14 23:09:15]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-11-14 23:09:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 23:13:14]

Description was changed from

==========
Cleanup fwl_* classes and cfx_* classes in fwl.

This CL cleans up the classes in the fwl_* and cfx_* files in fwl/core.
==========

to

==========
Cleanup fwl_* classes and cfx_* classes in fwl.

This CL cleans up the classes in the fwl_* and cfx_* files in fwl/core.

Committed:
https://pdfium.googlesource.com/pdfium/+/3439802410dc2c4aeb49397c987bf5ca0ddf...
==========

[commit-bot: I haz the power, 2016-11-14 23:13:15]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/3439802410dc2c4aeb49397c987bf5ca0ddf...