Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250163002: Update naming from OutputConfiguratorAnimation to DisplayConfiguratorAnimation (Closed)

Created:
6 years, 8 months ago by dnicoara
Modified:
6 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Update naming from OutputConfiguratorAnimation to DisplayConfiguratorAnimation BUG=333413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -345 lines) Patch
M ash/ash.gyp View 3 chunks +4 lines, -4 lines 0 comments Download
A + ash/display/display_configurator_animation.h View 3 chunks +9 lines, -9 lines 0 comments Download
A + ash/display/display_configurator_animation.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M ash/display/display_controller.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M ash/display/display_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D ash/display/output_configurator_animation.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ash/display/output_configurator_animation.cc View 1 chunk +0 lines, -227 lines 0 comments Download
M ash/shell.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/shell.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/shell_test_api.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
dnicoara
PTAL I think this is the last of the renames. No more Output* names!
6 years, 8 months ago (2014-04-23 20:11:53 UTC) #1
Jun Mukai
LGTM +oshima just in case
6 years, 8 months ago (2014-04-23 20:26:45 UTC) #2
Daniel Erat
lgtm thanks for doing this!
6 years, 8 months ago (2014-04-23 20:51:52 UTC) #3
oshima
lgtm++
6 years, 8 months ago (2014-04-23 22:03:17 UTC) #4
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-24 14:29:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/250163002/1
6 years, 8 months ago (2014-04-24 14:29:38 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:52:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 8 months ago (2014-04-24 14:52:47 UTC) #8
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 8 months ago (2014-04-24 19:24:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/250163002/1
6 years, 8 months ago (2014-04-24 21:10:37 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:17:18 UTC) #11
Message was sent while issue was closed. 
Change committed as 266034

Powered by Google App Engine
This is Rietveld 408576698