Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2500113004: Port convolve functions to SkOpts (Closed)

Created:
4 years, 1 month ago by xiangze.zhang
Modified:
4 years, 1 month ago
Reviewers:
mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Port convolve functions to SkOpts This patch moves the C++/SSE2/NEON implementations of convolve functions into the same place and uses SkOpts framework. Also some indentation fix. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2500113004 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/d2265e537c8015f8115d7b5b7f6de970aa688172

Patch Set 1 #

Patch Set 2 : Format #

Total comments: 6

Patch Set 3 : Rebase #

Patch Set 4 : Address comments #

Patch Set 5 : Address comments #

Patch Set 6 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1054 lines, -1240 lines) Patch
M gn/opts.gni View 3 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkBitmapScaler.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 3 chunks +84 lines, -89 lines 0 comments Download
M src/core/SkConvolver.h View 2 chunks +1 line, -29 lines 0 comments Download
M src/core/SkConvolver.cpp View 7 chunks +11 lines, -208 lines 0 comments Download
M src/core/SkOpts.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M src/core/SkOpts.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
A src/opts/SkBitmapFilter_opts.h View 1 2 3 4 5 1 chunk +940 lines, -0 lines 0 comments Download
D src/opts/SkBitmapFilter_opts_SSE2.h View 1 chunk +0 lines, -30 lines 0 comments Download
D src/opts/SkBitmapFilter_opts_SSE2.cpp View 1 chunk +0 lines, -450 lines 0 comments Download
M src/opts/SkBitmapProcState_arm_neon.cpp View 1 chunk +0 lines, -379 lines 0 comments Download
D src/opts/SkBitmapProcState_opts_arm.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_none.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
xiangze.zhang
PTAL. I have another question, I think I might as well bring up it here. ...
4 years, 1 month ago (2016-11-16 08:50:18 UTC) #4
mtklein_C
> I have another question, I think I might as well bring up it here. ...
4 years, 1 month ago (2016-11-16 14:07:31 UTC) #5
mtklein_C
I have only minor comments. This looks great. https://codereview.chromium.org/2500113004/diff/20001/src/opts/SkBitmapFilter_opts.h File src/opts/SkBitmapFilter_opts.h (right): https://codereview.chromium.org/2500113004/diff/20001/src/opts/SkBitmapFilter_opts.h#newcode17 src/opts/SkBitmapFilter_opts.h:17: #include ...
4 years, 1 month ago (2016-11-16 14:24:47 UTC) #6
xiangze.zhang
https://codereview.chromium.org/2500113004/diff/20001/src/opts/SkBitmapFilter_opts.h File src/opts/SkBitmapFilter_opts.h (right): https://codereview.chromium.org/2500113004/diff/20001/src/opts/SkBitmapFilter_opts.h#newcode17 src/opts/SkBitmapFilter_opts.h:17: #include <emmintrin.h> On 2016/11/16 14:24:47, mtklein_C wrote: > This ...
4 years, 1 month ago (2016-11-17 02:33:07 UTC) #11
xiangze.zhang
On 2016/11/16 14:07:31, mtklein_C wrote: > > I have another question, I think I might ...
4 years, 1 month ago (2016-11-17 02:38:51 UTC) #12
mtklein_C
On 2016/11/17 at 02:38:51, xiangze.zhang wrote: > On 2016/11/16 14:07:31, mtklein_C wrote: > > > ...
4 years, 1 month ago (2016-11-17 12:55:32 UTC) #13
mtklein_C
lgtm
4 years, 1 month ago (2016-11-17 12:56:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500113004/80001
4 years, 1 month ago (2016-11-17 12:56:09 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-mips64el-Debug-GN_Android-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-mips64el-Debug-GN_Android-Trybot/builds/2126)
4 years, 1 month ago (2016-11-17 13:00:18 UTC) #18
mtklein_C
On 2016/11/17 at 13:00:18, commit-bot wrote: > Try jobs failed on following builders: > Build-Ubuntu-Clang-mips64el-Debug-GN_Android-Trybot ...
4 years, 1 month ago (2016-11-17 13:09:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500113004/100001
4 years, 1 month ago (2016-11-18 02:09:16 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 02:39:41 UTC) #24
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d2265e537c8015f8115d7b5b7f6de970aa688172

Powered by Google App Engine
This is Rietveld 408576698