Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4421)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.h

Issue 2499793002: Refactoring how WebVR eye bounds are handled (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/vr_shell.h
diff --git a/chrome/browser/android/vr_shell/vr_shell.h b/chrome/browser/android/vr_shell/vr_shell.h
index 087181c0dd59a7ec00d8e05fa1a716961e23b8da..35c56fcd13fb909ba2d0e8286bb5fb54d1b6eee7 100644
--- a/chrome/browser/android/vr_shell/vr_shell.h
+++ b/chrome/browser/android/vr_shell/vr_shell.h
@@ -92,8 +92,8 @@ class VrShell : public device::GvrDelegate, content::WebContentsObserver {
// device::GvrDelegate implementation
void SetWebVRSecureOrigin(bool secure_origin) override;
void SubmitWebVRFrame() override;
- void UpdateWebVRTextureBounds(
- int eye, float left, float top, float width, float height) override;
+ void UpdateWebVRTextureBounds(const gvr::Rectf& left_bounds,
+ const gvr::Rectf& right_bounds) override;
gvr::GvrApi* gvr_api() override;
void SetGvrPoseForWebVr(const gvr::Mat4f& pose, uint32_t pose_num) override;
@@ -153,6 +153,8 @@ class VrShell : public device::GvrDelegate, content::WebContentsObserver {
std::unique_ptr<gvr::BufferViewport> buffer_viewport_;
std::unique_ptr<gvr::BufferViewport> headlocked_left_viewport_;
std::unique_ptr<gvr::BufferViewport> headlocked_right_viewport_;
+ std::unique_ptr<gvr::BufferViewport> webvr_left_viewport_;
+ std::unique_ptr<gvr::BufferViewport> webvr_right_viewport_;
std::unique_ptr<gvr::SwapChain> swap_chain_;
gvr::Sizei render_size_;
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/vr_shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698