Make PostTask and Send failures in input routing fatal.

Make PostTask and Send failures in input routing fatal.

It is possible that PostTask and Send might return false. I haven't been
able to get these to fail so this is a speculative change to see if these
scenarios are actually occurring.

BUG=615090
Crash renderer on IPC failures instead of getting into a hung renderer state.

Committed: https://crrev.com/014ed08b2160dd6ffbdee694a88746167d58096e
Cr-Commit-Position: refs/heads/master@{#431659}

[dtapuska, 2016-11-11 16:58:36]

The CQ bit was checked by dtapuska@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 16:58:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-11-11 16:58:51]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:43:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 17:43:22]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-11-11 18:01:52]

LGTM to help with diagnosis.

https://codereview.chromium.org/2499623002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.h (right):

https://codereview.chromium.org/2499623002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.h:815: // A variant of Send but is fatal if it
fails.
Please expand a bit in the comment to say why this is useful.

(Are we planning to keep this long term, or just until the bug is diagnosed?)

[dtapuska, 2016-11-11 19:09:52]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-11 19:09:52]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2499623002/#ps20001
(title: "Adjust comment")

[commit-bot: I haz the power, 2016-11-11 19:10:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:41:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:42:00]

Failed to apply patch for content/renderer/render_widget.h:
While running git apply --index -p1;
  error: patch failed: content/renderer/render_widget.h:812
  error: content/renderer/render_widget.h: patch does not apply

Patch:       content/renderer/render_widget.h
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index
dc1b377659a85dbc4d02814ad14242c7a6163357..4dcdc6c90a912a882388163a71b089a57d27c93e
100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -812,6 +812,13 @@ class CONTENT_EXPORT RenderWidget
                     blink::WebPopupType popup_type,
                     int32_t* routing_id);
 
+  // A variant of Send but is fatal if it fails. The browser may
+  // be waiting for this IPC Message and if the send fails the browser will
+  // be left in a state waiting for something that never comes. And if it
+  // never comes then it may later determine this is a hung renderer; so
+  // instead fail right away.
+  void SendOrCrash(IPC::Message* msg);
+
   // Indicates whether this widget has focus.
   bool has_focus_;

[dtapuska, 2016-11-11 20:46:35]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-11 20:46:36]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2499623002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-11-11 20:46:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:50:03]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dtapuska, 2016-11-11 20:52:41]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-11-11 20:52:42]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2499623002/#ps60001
(title: "Rebase again")

[commit-bot: I haz the power, 2016-11-11 20:53:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 21:59:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 22:22:28]

Description was changed from

==========
Make PostTask and Send failures in input routing fatal.

It is possible that PostTask and Send might return false. I haven't been
able to get these to fail so this is a speculative change to see if these
scenarios are actually occurring.

BUG=615090

Crash renderer on IPC failures instead of getting into a hung renderer state.
==========

to

==========
Make PostTask and Send failures in input routing fatal.

It is possible that PostTask and Send might return false. I haven't been
able to get these to fail so this is a speculative change to see if these
scenarios are actually occurring.

BUG=615090

Crash renderer on IPC failures instead of getting into a hung renderer state.

Committed: https://crrev.com/014ed08b2160dd6ffbdee694a88746167d58096e
Cr-Commit-Position: refs/heads/master@{#431659}
==========

[commit-bot: I haz the power, 2016-11-11 22:22:29]

Patchset 4 (id:??) landed as
https://crrev.com/014ed08b2160dd6ffbdee694a88746167d58096e
Cr-Commit-Position: refs/heads/master@{#431659}