Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2947)

Unified Diff: content/renderer/input/input_event_filter.cc

Issue 2499623002: Make PostTask and Send failures in input routing fatal. (Closed)
Patch Set: Rebase again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/input/input_event_filter.cc
diff --git a/content/renderer/input/input_event_filter.cc b/content/renderer/input/input_event_filter.cc
index a92e00e61b7c6f1a87e671be2ee8b435290918d2..063df1e101422751d8ce935038f8e5ff38f19e6c 100644
--- a/content/renderer/input/input_event_filter.cc
+++ b/content/renderer/input/input_event_filter.cc
@@ -178,9 +178,10 @@ bool InputEventFilter::OnMessageReceived(const IPC::Message& message) {
return false;
}
- target_task_runner_->PostTask(
+ CHECK(target_task_runner_->PostTask(
FROM_HERE, base::Bind(&InputEventFilter::ForwardToHandler, this, message,
- received_time));
+ received_time)))
+ << "PostTask failed";
return true;
}
@@ -198,7 +199,9 @@ void InputEventFilter::ForwardToHandler(const IPC::Message& message,
"input",
"InputEventFilter::ForwardToHandler::ForwardToMainListener",
TRACE_EVENT_SCOPE_THREAD);
- main_task_runner_->PostTask(FROM_HERE, base::Bind(main_listener_, message));
+ CHECK(main_task_runner_->PostTask(FROM_HERE,
+ base::Bind(main_listener_, message)))
+ << "PostTask failed";
return;
}
@@ -259,9 +262,10 @@ void InputEventFilter::DidForwardToHandlerAndOverscroll(
}
void InputEventFilter::SendMessage(std::unique_ptr<IPC::Message> message) {
- io_task_runner_->PostTask(
+ CHECK(io_task_runner_->PostTask(
FROM_HERE, base::Bind(&InputEventFilter::SendMessageOnIOThread, this,
- base::Passed(&message)));
+ base::Passed(&message))))
+ << "PostTask failed";
}
void InputEventFilter::SendMessageOnIOThread(
@@ -271,7 +275,7 @@ void InputEventFilter::SendMessageOnIOThread(
if (!sender_)
return; // Filter was removed.
- sender_->Send(message.release());
+ CHECK(sender_->Send(message.release())) << "Send message failed";
}
void InputEventFilter::HandleEventOnMainThread(
@@ -303,9 +307,10 @@ void InputEventFilter::NeedsMainFrame(int routing_id) {
return;
}
- target_task_runner_->PostTask(
+ CHECK(target_task_runner_->PostTask(
FROM_HERE,
- base::Bind(&InputEventFilter::NeedsMainFrame, this, routing_id));
+ base::Bind(&InputEventFilter::NeedsMainFrame, this, routing_id)))
+ << "PostTask failed";
}
} // namespace content
« no previous file with comments | « no previous file | content/renderer/render_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698