Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: content/renderer/render_widget.cc

Issue 2499623002: Make PostTask and Send failures in input routing fatal. (Closed)
Patch Set: Rebase again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 return false; 518 return false;
519 } 519 }
520 520
521 // If given a messsage without a routing ID, then assign our routing ID. 521 // If given a messsage without a routing ID, then assign our routing ID.
522 if (message->routing_id() == MSG_ROUTING_NONE) 522 if (message->routing_id() == MSG_ROUTING_NONE)
523 message->set_routing_id(routing_id_); 523 message->set_routing_id(routing_id_);
524 524
525 return RenderThread::Get()->Send(message); 525 return RenderThread::Get()->Send(message);
526 } 526 }
527 527
528 void RenderWidget::SendOrCrash(IPC::Message* message) {
529 bool result = Send(message);
530 CHECK(closing_ || result) << "Failed to send message";
531 }
532
528 void RenderWidget::SetWindowRectSynchronously( 533 void RenderWidget::SetWindowRectSynchronously(
529 const gfx::Rect& new_window_rect) { 534 const gfx::Rect& new_window_rect) {
530 ResizeParams params; 535 ResizeParams params;
531 params.screen_info = screen_info_; 536 params.screen_info = screen_info_;
532 params.new_size = new_window_rect.size(); 537 params.new_size = new_window_rect.size();
533 params.physical_backing_size = 538 params.physical_backing_size =
534 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_); 539 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_);
535 params.visible_viewport_size = new_window_rect.size(); 540 params.visible_viewport_size = new_window_rect.size();
536 params.is_fullscreen_granted = is_fullscreen_granted_; 541 params.is_fullscreen_granted = is_fullscreen_granted_;
537 params.display_mode = display_mode_; 542 params.display_mode = display_mode_;
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 void RenderWidget::ClearEditCommands() { 856 void RenderWidget::ClearEditCommands() {
852 edit_commands_.clear(); 857 edit_commands_.clear();
853 } 858 }
854 859
855 void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) { 860 void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) {
856 Send(new InputHostMsg_DidOverscroll(routing_id_, params)); 861 Send(new InputHostMsg_DidOverscroll(routing_id_, params));
857 } 862 }
858 863
859 void RenderWidget::OnInputEventAck( 864 void RenderWidget::OnInputEventAck(
860 std::unique_ptr<InputEventAck> input_event_ack) { 865 std::unique_ptr<InputEventAck> input_event_ack) {
861 Send(new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack)); 866 SendOrCrash(
867 new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack));
862 } 868 }
863 869
864 void RenderWidget::NotifyInputEventHandled( 870 void RenderWidget::NotifyInputEventHandled(
865 blink::WebInputEvent::Type handled_type, 871 blink::WebInputEvent::Type handled_type,
866 InputEventAckState ack_result) { 872 InputEventAckState ack_result) {
867 RenderThreadImpl* render_thread = RenderThreadImpl::current(); 873 RenderThreadImpl* render_thread = RenderThreadImpl::current();
868 InputHandlerManager* input_handler_manager = 874 InputHandlerManager* input_handler_manager =
869 render_thread ? render_thread->input_handler_manager() : NULL; 875 render_thread ? render_thread->input_handler_manager() : NULL;
870 if (input_handler_manager) { 876 if (input_handler_manager) {
871 input_handler_manager->NotifyInputEventHandledOnMainThread( 877 input_handler_manager->NotifyInputEventHandledOnMainThread(
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2086 blink::WebInputMethodController* RenderWidget::GetInputMethodController() 2092 blink::WebInputMethodController* RenderWidget::GetInputMethodController()
2087 const { 2093 const {
2088 // TODO(ekaramad): Remove this CHECK when GetWebWidget() is 2094 // TODO(ekaramad): Remove this CHECK when GetWebWidget() is
2089 // always a WebFrameWidget. 2095 // always a WebFrameWidget.
2090 CHECK(GetWebWidget()->isWebFrameWidget()); 2096 CHECK(GetWebWidget()->isWebFrameWidget());
2091 return static_cast<blink::WebFrameWidget*>(GetWebWidget()) 2097 return static_cast<blink::WebFrameWidget*>(GetWebWidget())
2092 ->getActiveWebInputMethodController(); 2098 ->getActiveWebInputMethodController();
2093 } 2099 }
2094 2100
2095 } // namespace content 2101 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698