Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2205)

Unified Diff: content/renderer/render_widget.cc

Issue 2499623002: Make PostTask and Send failures in input routing fatal. (Closed)
Patch Set: Rebase again Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index b540e2bbd859026f04474b46060faac615b1f868..7ba591929412c68020e5bf95e07ac757c3461d6f 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -525,6 +525,11 @@ bool RenderWidget::Send(IPC::Message* message) {
return RenderThread::Get()->Send(message);
}
+void RenderWidget::SendOrCrash(IPC::Message* message) {
+ bool result = Send(message);
+ CHECK(closing_ || result) << "Failed to send message";
+}
+
void RenderWidget::SetWindowRectSynchronously(
const gfx::Rect& new_window_rect) {
ResizeParams params;
@@ -858,7 +863,8 @@ void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) {
void RenderWidget::OnInputEventAck(
std::unique_ptr<InputEventAck> input_event_ack) {
- Send(new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack));
+ SendOrCrash(
+ new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack));
}
void RenderWidget::NotifyInputEventHandled(
« no previous file with comments | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698