Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)

Created:
4 years, 1 month ago by ncarter (slow)
Modified:
4 years ago
Reviewers:
alexmos
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify RenderFrameImpl::ResolveOpener() by removing the |opener_view_routing_id| optional param. In the prior patch set, we removed the last user of that param. BUG=627852 Committed: https://crrev.com/3b5a21f39ee24c516759e7ed9a7ed92b9157c266 Cr-Commit-Position: refs/heads/master@{#434015}

Patch Set 1 #

Patch Set 2 : Merge branch 'create-new-window5-5' into create_new_window6 #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -43 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 4 chunks +5 lines, -16 lines 0 comments Download
M content/renderer/render_frame_proxy.h View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (19 generated)
ncarter (slow)
Alex, please review (note that this depends on the other CL I also sent you)
4 years, 1 month ago (2016-11-16 17:53:08 UTC) #9
alexmos
LGTM, really happy to see this cleanup!
4 years, 1 month ago (2016-11-16 18:33:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499053003/40001
4 years ago (2016-11-22 22:02:17 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-22 23:07:44 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-22 23:10:00 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3b5a21f39ee24c516759e7ed9a7ed92b9157c266
Cr-Commit-Position: refs/heads/master@{#434015}

Powered by Google App Engine
This is Rietveld 408576698