Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 #include <memory> 9 #include <memory>
10 10
(...skipping 687 matching lines...) Expand 10 before | Expand all | Expand 10 after
698 698
699 void RenderViewImpl::Initialize( 699 void RenderViewImpl::Initialize(
700 const mojom::CreateViewParams& params, 700 const mojom::CreateViewParams& params,
701 const RenderWidget::ShowCallback& show_callback) { 701 const RenderWidget::ShowCallback& show_callback) {
702 bool was_created_by_renderer = !show_callback.is_null(); 702 bool was_created_by_renderer = !show_callback.is_null();
703 #if defined(OS_ANDROID) 703 #if defined(OS_ANDROID)
704 // TODO(sgurun): crbug.com/325351 Needed only for android webview's deprecated 704 // TODO(sgurun): crbug.com/325351 Needed only for android webview's deprecated
705 // HandleNavigation codepath. 705 // HandleNavigation codepath.
706 was_created_by_renderer_ = was_created_by_renderer; 706 was_created_by_renderer_ = was_created_by_renderer;
707 #endif 707 #endif
708 WebFrame* opener_frame =
709 RenderFrameImpl::ResolveOpener(params.opener_frame_route_id, nullptr);
710
711 display_mode_ = params.initial_size.display_mode; 708 display_mode_ = params.initial_size.display_mode;
712 709
713 webview_ = 710 webview_ =
714 WebView::create(this, is_hidden() ? blink::WebPageVisibilityStateHidden 711 WebView::create(this, is_hidden() ? blink::WebPageVisibilityStateHidden
715 : blink::WebPageVisibilityStateVisible); 712 : blink::WebPageVisibilityStateVisible);
716 RenderWidget::Init(show_callback, webview_->widget()); 713 RenderWidget::Init(show_callback, webview_->widget());
717 714
718 g_view_map.Get().insert(std::make_pair(webview(), this)); 715 g_view_map.Get().insert(std::make_pair(webview(), this));
719 g_routing_id_view_map.Get().insert(std::make_pair(GetRoutingID(), this)); 716 g_routing_id_view_map.Get().insert(std::make_pair(GetRoutingID(), this));
720 717
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 WebSettings::PassiveEventListenerDefault::False; 768 WebSettings::PassiveEventListenerDefault::False;
772 if (passiveListenersDefault == "true") 769 if (passiveListenersDefault == "true")
773 passiveDefault = WebSettings::PassiveEventListenerDefault::True; 770 passiveDefault = WebSettings::PassiveEventListenerDefault::True;
774 else if (passiveListenersDefault == "forcealltrue") 771 else if (passiveListenersDefault == "forcealltrue")
775 passiveDefault = WebSettings::PassiveEventListenerDefault::ForceAllTrue; 772 passiveDefault = WebSettings::PassiveEventListenerDefault::ForceAllTrue;
776 webview()->settings()->setPassiveEventListenerDefault(passiveDefault); 773 webview()->settings()->setPassiveEventListenerDefault(passiveDefault);
777 } 774 }
778 775
779 ApplyBlinkSettings(command_line, webview()->settings()); 776 ApplyBlinkSettings(command_line, webview()->settings());
780 777
778 WebFrame* opener_frame =
779 RenderFrameImpl::ResolveOpener(params.opener_frame_route_id);
780
781 if (params.main_frame_routing_id != MSG_ROUTING_NONE) { 781 if (params.main_frame_routing_id != MSG_ROUTING_NONE) {
782 main_render_frame_ = RenderFrameImpl::CreateMainFrame( 782 main_render_frame_ = RenderFrameImpl::CreateMainFrame(
783 this, params.main_frame_routing_id, params.main_frame_widget_routing_id, 783 this, params.main_frame_routing_id, params.main_frame_widget_routing_id,
784 params.hidden, screen_info(), compositor_deps_, opener_frame); 784 params.hidden, screen_info(), compositor_deps_, opener_frame);
785 } 785 }
786 786
787 if (params.proxy_routing_id != MSG_ROUTING_NONE) { 787 if (params.proxy_routing_id != MSG_ROUTING_NONE) {
788 CHECK(params.swapped_out); 788 CHECK(params.swapped_out);
789 RenderFrameProxy::CreateFrameProxy( 789 RenderFrameProxy::CreateFrameProxy(params.proxy_routing_id, GetRoutingID(),
790 params.proxy_routing_id, GetRoutingID(), params.opener_frame_route_id, 790 opener_frame, MSG_ROUTING_NONE,
791 MSG_ROUTING_NONE, params.replicated_frame_state); 791 params.replicated_frame_state);
792 } 792 }
793 793
794 if (main_render_frame_) 794 if (main_render_frame_)
795 main_render_frame_->Initialize(); 795 main_render_frame_->Initialize();
796 796
797 #if defined(OS_ANDROID) 797 #if defined(OS_ANDROID)
798 content_detectors_.push_back(base::MakeUnique<AddressDetector>()); 798 content_detectors_.push_back(base::MakeUnique<AddressDetector>());
799 const std::string& contry_iso = 799 const std::string& contry_iso =
800 params.renderer_preferences.network_contry_iso; 800 params.renderer_preferences.network_contry_iso;
801 if (!contry_iso.empty()) { 801 if (!contry_iso.empty()) {
(...skipping 2194 matching lines...) Expand 10 before | Expand all | Expand 10 after
2996 INPUT_EVENT_ACK_STATE_NOT_CONSUMED); 2996 INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
2997 } 2997 }
2998 2998
2999 std::unique_ptr<InputEventAck> ack( 2999 std::unique_ptr<InputEventAck> ack(
3000 new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type, 3000 new InputEventAck(InputEventAckSource::MAIN_THREAD, input_event->type,
3001 INPUT_EVENT_ACK_STATE_NOT_CONSUMED)); 3001 INPUT_EVENT_ACK_STATE_NOT_CONSUMED));
3002 OnInputEventAck(std::move(ack)); 3002 OnInputEventAck(std::move(ack));
3003 } 3003 }
3004 3004
3005 } // namespace content 3005 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698