Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: content/renderer/render_frame_proxy.h

Issue 2499053003: Simplify RenderFrameImpl::ResolveOpener() (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "content/common/content_export.h" 10 #include "content/common/content_export.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 RenderFrameImpl* frame_to_replace, 70 RenderFrameImpl* frame_to_replace,
71 int routing_id, 71 int routing_id,
72 blink::WebTreeScopeType scope); 72 blink::WebTreeScopeType scope);
73 73
74 // This method should be used to create a RenderFrameProxy, when there isn't 74 // This method should be used to create a RenderFrameProxy, when there isn't
75 // an existing RenderFrame. It should be called to construct a local 75 // an existing RenderFrame. It should be called to construct a local
76 // representation of a RenderFrame that has been created in another process -- 76 // representation of a RenderFrame that has been created in another process --
77 // for example, after a cross-process navigation or after the addition of a 77 // for example, after a cross-process navigation or after the addition of a
78 // new frame local to some other process. |routing_id| will be the ID of the 78 // new frame local to some other process. |routing_id| will be the ID of the
79 // newly created RenderFrameProxy. |render_view_routing_id| identifies the 79 // newly created RenderFrameProxy. |render_view_routing_id| identifies the
80 // RenderView to be associated with this frame. |opener_routing_id|, if 80 // RenderView to be associated with this frame. |opener|, if supplied, is the
81 // valid, is the routing ID of the new frame's opener. |parent_routing_id| 81 // new frame's opener. |parent_routing_id| is the routing ID of the
82 // is the routing ID of the RenderFrameProxy to which the new frame is 82 // RenderFrameProxy to which the new frame is parented.
83 // parented.
84 // 83 //
85 // |parent_routing_id| always identifies a RenderFrameProxy (never a 84 // |parent_routing_id| always identifies a RenderFrameProxy (never a
86 // RenderFrame) because a new child of a local frame should always start out 85 // RenderFrame) because a new child of a local frame should always start out
87 // as a frame, not a proxy. 86 // as a frame, not a proxy.
88 static RenderFrameProxy* CreateFrameProxy( 87 static RenderFrameProxy* CreateFrameProxy(
89 int routing_id, 88 int routing_id,
90 int render_view_routing_id, 89 int render_view_routing_id,
91 int opener_routing_id, 90 blink::WebFrame* opener,
92 int parent_routing_id, 91 int parent_routing_id,
93 const FrameReplicationState& replicated_state); 92 const FrameReplicationState& replicated_state);
94 93
95 // Returns the RenderFrameProxy for the given routing ID. 94 // Returns the RenderFrameProxy for the given routing ID.
96 static RenderFrameProxy* FromRoutingID(int routing_id); 95 static RenderFrameProxy* FromRoutingID(int routing_id);
97 96
98 // Returns the RenderFrameProxy given a WebFrame. 97 // Returns the RenderFrameProxy given a WebFrame.
99 static RenderFrameProxy* FromWebFrame(blink::WebFrame* web_frame); 98 static RenderFrameProxy* FromWebFrame(blink::WebFrame* web_frame);
100 99
101 ~RenderFrameProxy() override; 100 ~RenderFrameProxy() override;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 187
189 RenderViewImpl* render_view_; 188 RenderViewImpl* render_view_;
190 RenderWidget* render_widget_; 189 RenderWidget* render_widget_;
191 190
192 DISALLOW_COPY_AND_ASSIGN(RenderFrameProxy); 191 DISALLOW_COPY_AND_ASSIGN(RenderFrameProxy);
193 }; 192 };
194 193
195 } // namespace 194 } // namespace
196 195
197 #endif // CONTENT_RENDERER_RENDER_FRAME_PROXY_H_ 196 #endif // CONTENT_RENDERER_RENDER_FRAME_PROXY_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698